Skip to content

Add OneKey Classic 1S to wallet list#4655

Open
Shoyo1024 wants to merge 1 commit intobitcoin-dot-org:masterfrom
Shoyo1024:add-onekey-classic1s
Open

Add OneKey Classic 1S to wallet list#4655
Shoyo1024 wants to merge 1 commit intobitcoin-dot-org:masterfrom
Shoyo1024:add-onekey-classic1s

Conversation

@Shoyo1024
Copy link
Copy Markdown

This PR adds the OneKey Classic 1S hardware wallet to the wallet list, incorporating all feedback from the previous review at #4439 by @crwatkins.

Per @crwatkins's recommendation, this PR covers only the OneKey Classic 1S. OneKey Pro will be submitted in a separate PR once the remaining items on that device are resolved.

Firmware reviewed: v3.18.0 (https://github.com/OneKeyHQ/firmware-classic1s/releases/tag/v3.18.0)

Issues from #4439 addressed in this PR

  • Transparency score updated to checkpasstransparencyopenspechardware (per @crwatkins's recommendation, reflecting that the THD89 secure element is closed source while a public interface specification is now available for blackbox testing).
  • Description no longer claims "fully open source" — it now accurately describes the firmware as open source.
  • "Secure Elements" lowercased to "secure elements".
  • "Open-source" rewritten without the hyphen for consistency with the rest of the wallet list.

Issues from #4439 addressed outside this PR

cc @crwatkins

@crwatkins
Copy link
Copy Markdown
Contributor

These updates look good with one small exception:

  • New listings: With a max-age of at least 1 year, and preload and includeSubDomains directives to qualify for browser preload list inclusion e.g. Strict-Transport-Security: max-age=31536000; includeSubDomains; preload

onekey.so presents a max-age=15552000

Once this is corrected, I will happy to recommend OneKey Classic 1S for listing.

@Shoyo1024
Copy link
Copy Markdown
Author

Shoyo1024 commented Apr 13, 2026

Hi @crwatkins , just updated the HSTS header on onekey.so to max-age=31536000; includeSubDomains; preload. Should be good now.

@crwatkins
Copy link
Copy Markdown
Contributor

Looks good. I recommend OneKey Classic 1S for listing.

(You may want to consider preloading onekey.so at https://hstspreload.org/)

@Shoyo1024
Copy link
Copy Markdown
Author

Thanks Craig. Will get the HSTS preload submitted shortly.

@Shoyo1024
Copy link
Copy Markdown
Author

HSTS preload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants