merge master

.github/workflows/ghcr.io.yml

@@ -17,6 +17,7 @@ env:
 on:
   push:
     branches:
+      - master
       - main
       - v**
     tags:

.github/workflows/test_harness_workflow.yml

@@ -0,0 +1,28 @@
+name: Run Test Harness
+
+on:
+  push:
+    branches:
+      - master
+      - main
+  workflow_dispatch:
+
+jobs:
+  run-test-harness:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Repository
+        uses: actions/checkout@v3
+
+      - name: Build Docker Image
+        run: docker build -t miniscript-web .
+
+      - name: Run Docker Container
+        run: docker run -p 8080:8080 -d --name miniscript-test miniscript-web serve
+
+      - name: Execute Test Harness
+        run: ./test_harness.sh
+
+      - name: Clean up Docker Container
+        if: always()
+        run: docker stop miniscript-test && docker rm miniscript-test

.gitignore

@@ -1,4 +1,5 @@
 miniscript
+miniscript.json
 
 #make
 miniscript.js
@@ -11,3 +12,9 @@ apple-touch-icon.png
 
 #macos
 **.DS_Store**
+
+bash_profile.log
+buildx.dockerfile
+
+#genkit
+.genkit/

CHANGELOG.md

@@ -0,0 +1,29 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [Unreleased]
+
+### Added
+- New Miniscript function `do_nothing()` which compiles to `OP_1`.
+- Test script `test_bip110_output_limit_pkA.sh` to demonstrate BIP110 34-byte transaction output limit violation.
+- Test script `test_bip110_witness_stack_limit_sha256.sh` to demonstrate BIP110 256-byte witness stack element limit violation.
+- Test script `test_bip110_complex_scriptpubkey_limit.sh` to demonstrate BIP110 34-byte `scriptPubKey` limit violation with complex Miniscript.
+- Test script `test_bip110_op_return_data_limit.sh` to demonstrate BIP110 83-byte `OP_RETURN` data limit violation.
+- `test_harness.sh` script to run all BIP110 test scripts.
+- GitHub Actions workflow `.github/workflows/test_harness_workflow.yml` to automate running the test harness.
+
+### Changed
+- Added verbose logging (`set -x` and descriptive `echo`s) to all BIP110 test scripts for improved clarity and debuggability.
+- Modified `test_bip110_witness_stack_limit_sha256.sh` and `test_bip110_op_return_data_limit.sh` to dynamically detect Docker container ID and execute internal commands within the container for robustness.
+- Updated `test_bip110_complex_scriptpubkey_limit.sh` to use a here-document for robust multi-line output.
+
+### Fixed
+- Corrected shell syntax errors in `test_bip110_complex_scriptpubkey_limit.sh` and `test_bip110_op_return_data_limit.sh` related to unescaped characters and command execution.
+- Installed `xxd` in the Docker container to support hex encoding in `test_bip110_op_return_data_limit.sh`.
+
+### Chore
+- Added `.genkit/` to `.gitignore` to prevent tracking local Genkit-related files.

CNAME

@@ -0,0 +1 @@
+github.miniscript.app

Dockerfile

@@ -10,34 +10,28 @@ RUN apt-get install systemd bash jq -y
 RUN echo $(date +%s) > updated
 RUN chmod +x /usr/bin/systemctl
 RUN echo $(date +%s) > updated
-FROM systemd as pandoc
-RUN apt-get install pandoc -y
-RUN echo $(date +%s) > updated
-FROM pandoc as docker
-RUN apt-get install docker.io -y
-RUN echo $(date +%s) > updated
-FROM docker as clone
+FROM systemd as clone
 RUN rm -rf /src
-RUN git clone --branch v0.0.2 --depth 1 https://github.com/bitcoincore-dev/miniscript-docker /src
+RUN git clone --branch v0.0.10 --depth 1 https://github.com/bitcoincore-dev/miniscript-docker /src
 RUN echo $(date +%s) > updated
 FROM clone as make
 WORKDIR /src
 RUN make miniscript
 RUN echo $(date +%s) > updated
 RUN install miniscript /usr/local/bin
 RUN echo $(date +%s) > updated
-RUN make miniscript.js
-RUN echo $(date +%s) > updated
+RUN make miniscript.js ##TODO: better buildx multiplatform building
+#RUN echo $(date +%s) > updated
 FROM make as install
 RUN install ./miniscript /usr/local/bin
 RUN echo $(date +%s) > updated
-RUN install ./miniscript-* /usr/local/bin
+RUN install ./miniscript-** /usr/local/bin
 RUN install ./serve /usr/local/bin
 RUN echo $(date +%s) > updated
 WORKDIR /src
 FROM install as miniscript
 COPY --from=clone /src /src
 ENV PATH=$PATH:/usr/bin/systemctl
 RUN ps -p 1 -o comm=
-EXPOSE 80 6102 8080 8081
+EXPOSE 80 443 6102 8080 8081
 VOLUME /src

GNUmakefile

@@ -1,3 +1,15 @@
+## detect ARCH for buildx
+ARCH                                   :=$(shell uname -m)
+export ARCH
+ifeq ($(ARCH),x86_64)
+TARGET                                 :=amd64
+export TARGET
+endif
+ifeq ($(ARCH),arm64)
+TARGET                                 :=arm64
+export TARGET
+endif
+
 DOCKER=$(shell which docker)
 export DOCKER
 PWD=$(shell echo `pwd`)
@@ -12,21 +24,32 @@ install:
 	@rm ./miniscript || true
 	@rm /usr/local/bin/miniscript || true
 	@$(MAKE) miniscript
+	@$(MAKE) miniscript.json
 	@install $(PWD)/miniscript        /usr/local/bin/
 	@install $(PWD)/miniscript-*      /usr/local/bin/
+	@install $(PWD)/miniscript.json   /usr/local/bin/
+	@install $(PWD)/miniscript.json-* /usr/local/bin/
 
 docker:docker-miniscript## 	        docker-build
+dockerx:docker-buildx## 	        docker-buildx
 docker-build:## 		docker build -f Dockerfile -t miniscript .
 	@./miniscript-docker start
 	@$(DOCKER) pull ghcr.io/bitcoincore-dev/miniscript-docker:latest
 	@$(DOCKER) build -f Dockerfile -t miniscript .
+docker-buildx:## 		docker buildx build sequence
+	@./miniscript-docker start
+	@$(DOCKER) run --privileged --rm tonistiigi/binfmt --install all
+	@$(DOCKER) buildx ls
+	@$(DOCKER) buildx create --use --name miniscript-buildx || true
+	@$(DOCKER) buildx build -t miniscript --platform linux/arm64,linux/amd64 .
+	@$(DOCKER) buildx build -t miniscript --platform linux/$(TARGET) . --load
 docker-miniscript:docker-build## 		docker-miniscript
 	@[[ -z "$(shell file ./miniscript | grep inux)" ]] && echo "not linux" && rm ./miniscript || echo "miniscript is built for linux"
 	@$(DOCKER) run --rm -v $(PWD):/src --publish 80:8080  miniscript sh -c "make install"
 
-.PHONY:test-command
-test-command:
-	@cat $< $@ && exit;
+.PHONY:miniscript-tests
+miniscript-tests:## 	miniscript-tests
+	@bash $< $@ 2>/dev/null || true
 
 example-commands:
 	@printf "\n"

Makefile

@@ -1,9 +1,12 @@
 HEADERS := bitcoin/util/vector.h bitcoin/util/strencodings.h bitcoin/span.h bitcoin/util/spanparsing.h bitcoin/script/script.h bitcoin/script/miniscript.h compiler.h bitcoin/crypto/common.h bitcoin/serialize.h bitcoin/prevector.h bitcoin/compat/endian.h bitcoin/compat/byteswap.h bitcoin/attributes.h bitcoin/tinyformat.h bitcoin/primitives/transaction.h
 SOURCES := bitcoin/util/strencodings.cpp bitcoin/util/spanparsing.cpp bitcoin/script/script.cpp bitcoin/script/miniscript.cpp compiler.cpp
 
-miniscript: $(HEADERS) $(SOURCES) main.cpp
+miniscript: $(HEADERS) $(SOURCES) main.cpp## 		miniscript
 	g++ -O3 -g0 -Wall -std=c++17 -march=native -flto -Ibitcoin $(SOURCES) main.cpp -o miniscript
 
+miniscript.json: $(HEADERS) $(SOURCES) miniscript.json.cpp## 		miniscript.json
+	g++ -O3 -g0 -Wall -std=c++17 -march=native -flto -Ibitcoin $(SOURCES) miniscript.json.cpp -o miniscript.json
+
 miniscript.js: $(HEADERS) $(SOURCES) js_bindings.cpp
 	em++ -O3 -g0 -Wall -std=c++17 -fno-rtti -flto -Ibitcoin $(SOURCES) js_bindings.cpp -s WASM=1 -s FILESYSTEM=0 -s ENVIRONMENT=web -s DISABLE_EXCEPTION_CATCHING=0 -s EXPORTED_FUNCTIONS='["_miniscript_compile","_miniscript_analyze","_malloc","_free"]' -s EXPORTED_RUNTIME_METHODS='["cwrap","UTF8ToString"]' -o miniscript.js
 
@@ -13,4 +16,4 @@ wrapper.dot: wrapper.txt
 wrapper.pdf: wrapper.dot
 	dot -Tpdf <wrapper.dot >wrapper.pdf
 
-.PHONY:miniscript miniscript.js
+.PHONY:miniscript miniscript.js miniscript.json

README.md

@@ -1,5 +1,8 @@
 ## miniscript-docker
 
+![miniscript-docker-web](https://github.com/bitcoincore-dev/miniscript-docker/assets/152159/287c6835-b14c-4ae5-a22b-6da9812a8f8d)
+
+
 #### Usage:
 
 ```
@@ -27,16 +30,16 @@ docker pull ghcr.io/bitcoincore-dev/miniscript-docker:latest
 
 
 ```
-miniscript-docker run 'and(pk(A),or(pk(B),or(9@pk(C),older(1000))))'
+/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/bitcoincore-dev/miniscript-docker/master/miniscript-docker)" - run 'and(pk(A),or(pk(B),or(9@pk(C),older(1000))))'
 ```
 
+![miniscript-docker-run 1](https://github.com/bitcoincore-dev/miniscript-docker/assets/152159/7f1b02db-7063-41c2-859c-33639eb82d5a)
 
 ```
-miniscript-docker run 'and_v(or_c(pk(B),or_c(pk(C),v:older(1000))),pk(A))'
+/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/bitcoincore-dev/miniscript-docker/master/miniscript-docker)" - run 'and_v(or_c(pk(B),or_c(pk(C),v:older(1000))),pk(A))'
 ```
 
-
-EXAMPLES
+![miniscript-docker-run 2 png](https://github.com/bitcoincore-dev/miniscript-docker/assets/152159/1da94b41-ad45-4bda-8113-fa7b4f1326d5)
 
 ##### miniscript-docker examples
 
@@ -46,6 +49,16 @@ EXAMPLES
 
 ![miniscript-docker-examples](https://github.com/bitcoincore-dev/miniscript-docker/assets/152159/a9b7e0d6-bcdf-4e86-abe7-0af4dd3b887e)
 
+
+##### miniscript-docker serve
+
+```
+/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/bitcoincore-dev/miniscript-docker/master/miniscript-docker)" - serve
+```
+
+![miniscript-docker-web](https://github.com/bitcoincore-dev/miniscript-docker/assets/152159/287c6835-b14c-4ae5-a22b-6da9812a8f8d)
+
+
 <hr>
 
 Go to [the Miniscript website](http://bitcoin.sipa.be/miniscript/).

bitcoin/script/miniscript.h

@@ -591,6 +591,7 @@ struct Node {
                 case Fragment::WRAP_J: return BuildScript(OP_SIZE, OP_0NOTEQUAL, OP_IF, subs[0], OP_ENDIF);
                 case Fragment::WRAP_N: return BuildScript(std::move(subs[0]), OP_0NOTEQUAL);
                 case Fragment::JUST_1: return BuildScript(OP_1);
+                case Fragment::DO_NOTHING: return BuildScript(OP_1);
                 case Fragment::JUST_0: return BuildScript(OP_0);
                 case Fragment::AND_V: return BuildScript(std::move(subs[0]), subs[1]);
                 case Fragment::AND_B: return BuildScript(std::move(subs[0]), subs[1], OP_BOOLAND);
@@ -688,6 +689,7 @@ struct Node {
                 case Fragment::RIPEMD160: return std::move(ret) + "ripemd160(" + HexStr(node.data) + ")";
                 case Fragment::JUST_1: return std::move(ret) + "1";
                 case Fragment::JUST_0: return std::move(ret) + "0";
+                case Fragment::DO_NOTHING: return std::move(ret) + "do_nothing()";
                 case Fragment::AND_V: return std::move(ret) + "and_v(" + std::move(subs[0]) + "," + std::move(subs[1]) + ")";
                 case Fragment::AND_B: return std::move(ret) + "and_b(" + std::move(subs[0]) + "," + std::move(subs[1]) + ")";
                 case Fragment::OR_B: return std::move(ret) + "or_b(" + std::move(subs[0]) + "," + std::move(subs[1]) + ")";
@@ -727,6 +729,7 @@ struct Node {
         switch (fragment) {
             case Fragment::JUST_1: return {0, 0, {}};
             case Fragment::JUST_0: return {0, {}, 0};
+            case Fragment::DO_NOTHING: return {0, 0, {}};
             case Fragment::PK_K: return {0, 0, 0};
             case Fragment::PK_H: return {3, 0, 0};
             case Fragment::OLDER:
@@ -799,6 +802,7 @@ struct Node {
     internal::StackSize CalcStackSize() const {
         switch (fragment) {
             case Fragment::JUST_0: return {{}, 0};
+            case Fragment::DO_NOTHING:
             case Fragment::JUST_1:
             case Fragment::OLDER:
             case Fragment::AFTER: return {0, {}};
@@ -1014,6 +1018,7 @@ struct Node {
                     return {INVALID, std::move(x.sat)};
                 }
                 case Fragment::JUST_0: return {EMPTY, INVALID};
+                case Fragment::DO_NOTHING: return {INVALID, EMPTY};
                 case Fragment::JUST_1: return {INVALID, EMPTY};
             }
             assert(false);
@@ -1168,6 +1173,7 @@ struct Node {
             switch (node.fragment) {
                 case Fragment::JUST_0:
                     return false;
+                case Fragment::DO_NOTHING:
                 case Fragment::JUST_1:
                     return true;
                 case Fragment::PK_K:

compiler.cpp

@@ -333,6 +333,9 @@ const Strat* ComputeStrategy(const Policy& node, std::unordered_map<const Policy
             strats.push_back(MakeStrat(store, Strat::Type::THRESH, subs, node.k, (double)node.k / subs.size()));
             break;
         }
+        case Policy::Type::DO_NOTHING:
+            strats.push_back(MakeStrat(store, Strat::Type::JUST_1));
+            break;
     }
 
     if (strats.size() != 1) {
@@ -498,6 +501,7 @@ CostPair CalcCostPair(Fragment nt, const std::vector<const Result*>& s, double l
         case Fragment::WRAP_J: return {s[0]->pair.sat, 1};
         case Fragment::JUST_1: return {0, INF};
         case Fragment::JUST_0: return {INF, 0};
+        case Fragment::DO_NOTHING: return {0, INF};
         case Fragment::AND_V: return {s[0]->pair.sat + s[1]->pair.sat, INF};
         case Fragment::AND_B: return {s[0]->pair.sat + s[1]->pair.sat, s[0]->pair.nsat + s[1]->pair.nsat};
         case Fragment::OR_B:
@@ -604,6 +608,7 @@ const TypeFilters& GetTypeFilter(Fragment nt) {
         case Fragment::HASH160:
         case Fragment::SHA256:
         case Fragment::RIPEMD160:
+        case Fragment::DO_NOTHING:
             return FILTER_NO;
         case Fragment::WRAP_A: return FILTER_WRAP_A;
         case Fragment::WRAP_S: return FILTER_WRAP_S;
@@ -712,6 +717,9 @@ void Compile(const Strat* strat, Compilation& compilation, std::map<CompilationK
         case Strat::Type::JUST_1:
             Add(compilation, cache, Fragment::JUST_1, strat->sub, 0, 0);
             return;
+        case Strat::Type::DO_NOTHING:
+            Add(compilation, cache, Fragment::JUST_1, strat->sub, 0, 0);
+            return;
         case Strat::Type::AFTER:
         case Strat::Type::OLDER: {
             Add(compilation, cache, strat->node_type == Strat::Type::OLDER ? Fragment::OLDER : Fragment::AFTER, strat->sub, 0, 0, strat->k);

main.cpp

@@ -17,49 +17,13 @@ static bool run(std::string&& line, int64_t count) {
     miniscript::NodeRef<std::string> ret;
     double avgcost = 0;
     if (Compile(Expand(line), ret, avgcost)) {
-
         auto str = ret->ToString(COMPILER_CTX);
-
         assert(str);
-
-        printf(
-				"\n{ \"X\":\"X\",\n\"2\":\"%17.10f\",\n\"3\":\"%5i\",\n\"4\":\"%s\"\n }\n",
-				ret->ScriptSize() + avgcost, (int)ret->ScriptSize(),
-				Abbreviate(std::move(*str)).c_str()
-				);
-
+        printf("X %17.10f %5i %s %s\n", ret->ScriptSize() + avgcost, (int)ret->ScriptSize(), Abbreviate(std::move(*str)).c_str(), line.c_str());
     } else if ((ret = miniscript::FromString(Expand(line), COMPILER_CTX))) {
-
         auto ms = ret->ToString(COMPILER_CTX);
-		assert(ms);
-		printf("{ \"count\": \"%7li\",\n",(long)count);
-		printf("\"scriptlen\" : \"%i\",\n",(int)ret->ScriptSize());
-		printf("\"maxops\" : \"%i\",\n",(int)ret->GetOps());
-		printf("\"type\" : \"%s\",\n",ret->GetType() << "B"_mst ? "B" : ret->GetType() << "V"_mst ? "V" : ret->GetType() << "W"_mst ? "W" : ret->GetType() << "K"_mst ? "K" : "(invalid)");
-
-		printf("\"safe\" : \"%s\",\n",ret->GetType() << "s"_mst ? "yes" : "no");
-		printf("\"nonmal\" : \"%s\",\n",ret->GetType() << "m"_mst ? "yes" : "no");
-		printf("\"dissat\" : \"%s\",\n",ret->GetType() << "f"_mst ? "no" : ret->GetType() << "e"_mst ? "unique" : ret->GetType() << "d"_mst ? "yes" : "unknown");
-		printf("\"input\" : \"%s\",\n",ret->GetType() << "z"_mst ? "0" : ret->GetType() << "o"_mst ? (ret->GetType() << "n"_mst ? "1n" : "1") : ret->GetType() << "n"_mst ? "n" : "-");
-		printf("\"output\" : \"%s\",\n",ret->GetType() << "u"_mst ? "1" : "nonzero");
-		printf("\"timelock_mix\" : \"%s\",\n",ret->GetType() << "k"_mst ? "no": "yes");
-		printf("\"miniscript\" : \"%s\" }\n",Abbreviate(*ms).c_str());
-
-
-
         assert(ms);
-// 		printf("%7li\nscriptlen=%i\nmaxops=%i\ntype=%s\nsafe=%s\nnonmal=%s\ndissat=%s\ninput=%s\noutput=%s\ntimelock_mix=%s\nminiscript=%s\n",
-// (long)count,
-// (int)ret->ScriptSize(),
-// (int)ret->GetOps(),
-// ret->GetType() << "B"_mst ? "B" : ret->GetType() << "V"_mst ? "V" : ret->GetType() << "W"_mst ? "W" : ret->GetType() << "K"_mst ? "K" : "(invalid)",
-// ret->GetType() << "s"_mst ? "yes" : "no",
-// ret->GetType() << "m"_mst ? "yes" : "no",
-// ret->GetType() << "f"_mst ? "no" : ret->GetType() << "e"_mst ? "unique" : ret->GetType() << "d"_mst ? "yes" : "unknown",
-// ret->GetType() << "z"_mst ? "0" : ret->GetType() << "o"_mst ? (ret->GetType() << "n"_mst ? "1n" : "1") : ret->GetType() << "n"_mst ? "n" : "-",
-// ret->GetType() << "u"_mst ? "1" : "nonzero",
-// ret->GetType() << "k"_mst ? "no": "yes",
-// Abbreviate(*ms).c_str());
+        printf("%7li scriptlen=%i maxops=%i type=%s safe=%s nonmal=%s dissat=%s input=%s output=%s timelock_mix=%s miniscript=%s\n", (long)count, (int)ret->ScriptSize(), (int)ret->GetOps(), ret->GetType() << "B"_mst ? "B" : ret->GetType() << "V"_mst ? "V" : ret->GetType() << "W"_mst ? "W" : ret->GetType() << "K"_mst ? "K" : "(invalid)", ret->GetType() << "s"_mst ? "yes" : "no", ret->GetType() << "m"_mst ? "yes" : "no", ret->GetType() << "f"_mst ? "no" : ret->GetType() << "e"_mst ? "unique" : ret->GetType() << "d"_mst ? "yes" : "unknown", ret->GetType() << "z"_mst ? "0" : ret->GetType() << "o"_mst ? (ret->GetType() << "n"_mst ? "1n" : "1") : ret->GetType() << "n"_mst ? "n" : "-", ret->GetType() << "u"_mst ? "1" : "nonzero", ret->GetType() << "k"_mst ? "no": "yes", Abbreviate(*ms).c_str());
     } else {
         printf("Failed to parse as policy or miniscript '%s'\n", line.c_str());
     }

miniscript-docker

@@ -183,11 +183,10 @@ function shell (){
     docker-start
     docker \
         run \
-        -d \
         -t \
         -i \
         --rm \
-        -p 127.0.0.1:$PORT:8080/tcp \
+        -p 127.0.0.1:0:8080/tcp \
         -v `pwd`:/src miniscript bash
 
 }

miniscript-test-0

@@ -0,0 +1,3 @@
+#!/usr/bin/env bash
+#
+echo "or_i(and_v(v:thresh(2,pkh(M1),a:pkh(M2),a:pkh(M3)),after(1005)),and_v(v:thresh(2,pk(P1),s:pk(P2),s:pk(P3),sun:after(1002),sun:after(1003)),and_v(or_c(pk(SA1),or_c(pk(SA3),v:pkh(SA2))),thresh(2,pk(A1),s:pk(A2),s:pk(A3),sln:after(1004)))))" | miniscript