Skip to content

feat: expose TxBuilder coin selection#1033

Merged
reez merged 1 commit into
bitcoindevkit:masterfrom
reez:txbuilder-coin-selection
Jun 30, 2026
Merged

feat: expose TxBuilder coin selection#1033
reez merged 1 commit into
bitcoindevkit:masterfrom
reez:txbuilder-coin-selection

Conversation

@reez

@reez reez commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Description

Exposes TxBuilder::coin_selection so people can choose the wallet coin selection algo when building transactions.

Notes to the reviewers

Looking for feedback on if we think this is something we want to do or not

Documentation

Changelog

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing
  • I've added exactly one changelog:* label
  • I've linked the relevant upstream docs or specs above

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez marked this pull request as ready for review June 17, 2026 19:01
@reez reez force-pushed the txbuilder-coin-selection branch from 6016d96 to 9f9233a Compare June 25, 2026 18:24
@reez

reez commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

reviewable+rebased

@reez reez requested review from ItoroD and thunderbiscuit June 25, 2026 18:27

@thunderbiscuit thunderbiscuit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9f9233a.

It took me a bit of time to dig in and understand the requirement for the new method but I suspected an issue with the generics of the coin selection algo, which was indeed the case.

Thanks for adding this!

My only little thing I would like to have somewhere in the API docs is a statement of which coin selection is used if none is defined. We could maybe add it to the new enum?

I'll open an issue on the Rust side to bring that up as well.

@reez reez force-pushed the txbuilder-coin-selection branch from 9f9233a to 8806ad5 Compare June 30, 2026 14:10
@reez

reez commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator Author

rebased

@reez reez merged commit 8806ad5 into bitcoindevkit:master Jun 30, 2026
8 checks passed
@reez reez deleted the txbuilder-coin-selection branch June 30, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants