feat(transaction): expose to_bytes() and from_bytes() for consensus serialization#39
Merged
darioAnongba merged 3 commits intomainfrom Mar 16, 2026
Merged
Conversation
…erialization Add Transaction.to_bytes() and Transaction.from_bytes() methods that serialize/deserialize to consensus-encoded bytes (BIP144 format). This enables passing transactions between WASM modules (e.g. BDK -> LDK), broadcasting via external APIs, and storing raw transactions. wasm_bindgen automatically converts Vec<u8> <-> Uint8Array for the JS API. Closes #38
Collaborator
Author
|
Missing tests? |
- Round-trip serialization with known mainnet transactions - Coinbase tx (block 170) and Satoshi's first spend - Error cases: empty bytes, truncated, garbage input - Property verification after deserialization - Multiple round-trip stability test
Per review — the implementation is trivial (thin wrapper around
bitcoin::consensus::{serialize,deserialize}), tests add more
maintenance burden than value.
|
Thanks, @darioAnongba. How often are you releasing new versions of this package? |
Collaborator
Author
There is no fixed schedule. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
Transaction.to_bytes()andTransaction.from_bytes()methods for consensus-encoded byte serialization/deserialization.Motivation
The
Transactiontype currently has no serialization path, making it impossible to:Every other major type (
Psbt,ChangeSet) has serialization —Transactionwas the gap.API
Implementation
Thin wrapper around
bitcoin::consensus::serialize/deserialize.wasm_bindgenhandlesVec<u8>↔Uint8Arrayconversion automatically. Trivial enough that dedicated tests would be more maintenance than value.Use case: LDK channel funding
Closes #38