fix(wallet): map keychain in mark_used and unmark_used#507
Open
evanlinjin wants to merge 1 commit into
Open
Conversation
`mark_used` and `unmark_used` passed the caller-supplied `KeychainKind` straight to the index. For single-descriptor wallets, this meant marking or unmarking an index on `Internal` was a no-op, since that wallet only tracks the `External` keychain. Route the keychain through `map_keychain` first, consistent with the other methods that take a `KeychainKind`, so a single-keychain wallet resolves `Internal` to `External`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #507 +/- ##
==========================================
+ Coverage 80.96% 80.97% +0.01%
==========================================
Files 24 24
Lines 5489 5493 +4
Branches 247 247
==========================================
+ Hits 4444 4448 +4
Misses 968 968
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The bug that is fixed:
Wallet::mark_usedandWallet::unmark_usedpassed the caller-suppliedKeychainKindstraight through to the underlying index. For single-descriptor wallets, this meant marking or unmarking an index onKeychainKind::Internalwas a silent no-op.Changelog notice
Before submitting
- [ ] This PR breaks the existing API