fix: include file extension for relative paths in ESM#27
Closed
dav1app wants to merge 1 commit intobitcoinjs:masterfrom
dav1app:fix/native-esm-requires-file-extension
Closed
fix: include file extension for relative paths in ESM#27dav1app wants to merge 1 commit intobitcoinjs:masterfrom dav1app:fix/native-esm-requires-file-extension
dav1app wants to merge 1 commit intobitcoinjs:masterfrom
dav1app:fix/native-esm-requires-file-extension
Conversation
Merged
Member
|
Fixed in #29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes
.jsextensions over relative paths inimportsSee NodeJS official docs on mandatory .js extensions for relative paths when using ESM
Minor change, but this allows non-TSX/ts-node environments to properly import this code.
I encountered this issue while handling some tests with
vitest. I can provide a reproducible environment, but it should be as small as creating a test and importing this code.Notice that this is fixed on tiny-secp256k1