fix compilation error with later 3.0.x versions of arduino-esp32#96
Merged
bitluni merged 2 commits intobitluni:masterfrom Feb 23, 2026
Merged
fix compilation error with later 3.0.x versions of arduino-esp32#96bitluni merged 2 commits intobitluni:masterfrom
bitluni merged 2 commits intobitluni:masterfrom
Conversation
Contributor
Author
|
The second commit addresses a probable bug which would have always caused a buffer allocation. |
Contributor
Author
|
Hey @bitluni was wondering if this had fallen between the cracks? If you have problems with it, I'm happy to address them! |
Owner
|
sorry, I'm bad at this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a compilation error in
VGA.h:It looks as if this became an error sometime between version 3.0.3 and 3.0.7.
I'm also getting a lot of compiler warnings. I can have a go at fixing these as well if you'd like?
Cheers,
Steve