Skip to content

Comments

fix compilation error with later 3.0.x versions of arduino-esp32#96

Merged
bitluni merged 2 commits intobitluni:masterfrom
jscrane:master
Feb 23, 2026
Merged

fix compilation error with later 3.0.x versions of arduino-esp32#96
bitluni merged 2 commits intobitluni:masterfrom
jscrane:master

Conversation

@jscrane
Copy link
Contributor

@jscrane jscrane commented Jan 12, 2025

This fixes a compilation error in VGA.h:

/home/steve/Arduino/libraries/ESP32Lib/src/VGA/VGA.h: In member function 'virtual bool VGA::init(const Mode&, const int*, int, int)':
/home/steve/Arduino/libraries/ESP32Lib/src/VGA/VGA.h:36:10: error: no return statement in function returning non-void [-Werror=return-type]
   36 |         {}

It looks as if this became an error sometime between version 3.0.3 and 3.0.7.

I'm also getting a lot of compiler warnings. I can have a go at fixing these as well if you'd like?

Cheers,
Steve

@jscrane
Copy link
Contributor Author

jscrane commented Jan 12, 2025

The second commit addresses a probable bug which would have always caused a buffer allocation.

@otiskujawa
Copy link

otiskujawa commented Mar 20, 2025

Thanks
This fixes #98 and #97 therefore making 4.0 usable again

@jscrane
Copy link
Contributor Author

jscrane commented Feb 19, 2026

Hey @bitluni was wondering if this had fallen between the cracks? If you have problems with it, I'm happy to address them!

@bitluni bitluni merged commit 35b17d2 into bitluni:master Feb 23, 2026
@bitluni
Copy link
Owner

bitluni commented Feb 23, 2026

sorry, I'm bad at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants