feat: Add error logs for spiders and deploys#281
Merged
Conversation
6687f59 to
c925849
Compare
joaquingx
reviewed
May 26, 2026
joaquingx
left a comment
Contributor
There was a problem hiding this comment.
Nice work overall — the friendly error reasons + traceback extraction will be a meaningful UX improvement. Leaving a batch of comments specifically on the Celery side; please take a look before merge.
c925849 to
e2d017e
Compare
joaquingx
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes, relevant motivation and context.
Issue
Checklist before requesting a review