Skip to content

feat: Add error logs for spiders and deploys#281

Merged
erick-GeGe merged 2 commits into
mainfrom
feat/show-error-logs
Jun 4, 2026
Merged

feat: Add error logs for spiders and deploys#281
erick-GeGe merged 2 commits into
mainfrom
feat/show-error-logs

Conversation

@erick-GeGe

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the changes, relevant motivation and context.

Issue

  • Github Issue ID.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines of this project.
  • I have made corresponding changes to the documentation.
  • New and existing tests pass locally with my changes.
  • If this change is a core feature, I have added thorough tests.
  • If this change affects or depends on the behavior of other estela repositories, I have created pull requests with the relevant changes in the affected repositories. Please, refer to our official documentation.
  • I understand that my pull request may be closed if it becomes obvious or I did not perform all of the steps above.

@erick-GeGe erick-GeGe force-pushed the feat/show-error-logs branch from 6687f59 to c925849 Compare May 8, 2026 14:33
@erick-GeGe erick-GeGe requested review from jc99k and joaquingx May 26, 2026 14:48

@joaquingx joaquingx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work overall — the friendly error reasons + traceback extraction will be a meaningful UX improvement. Leaving a batch of comments specifically on the Celery side; please take a look before merge.

Comment thread estela-api/config/celery.py Outdated
Comment thread estela-api/core/tasks.py Outdated
Comment thread estela-api/core/tasks.py Outdated
Comment thread estela-api/core/tasks.py Outdated
Comment thread estela-api/core/tasks.py
Comment thread estela-api/core/tasks.py Outdated
Comment thread estela-api/core/tasks.py Outdated
Comment thread estela-api/core/tasks.py Outdated
@erick-GeGe erick-GeGe force-pushed the feat/show-error-logs branch from c925849 to e2d017e Compare May 28, 2026 17:07
@erick-GeGe erick-GeGe merged commit be60859 into main Jun 4, 2026
1 check passed
@erick-GeGe erick-GeGe deleted the feat/show-error-logs branch June 4, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants