Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .codex/skills/review-and-merge-pr/agents/openai.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
interface:
display_name: "Review and Merge PR"
short_description: "Check PR feedback, fix valid findings, and merge when ready"
default_prompt: "Review the current PR, address valid bot or human feedback, and merge it when ready."
4 changes: 4 additions & 0 deletions .cursor/skills/review-and-merge-pr/agents/openai.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
interface:
display_name: "Review and Merge PR"
short_description: "Check PR feedback, fix valid findings, and merge when ready"
default_prompt: "Review the current PR, address valid bot or human feedback, and merge it when ready."
1 change: 1 addition & 0 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ This repo is a temporary fork of [plebbit/plebbit-react-hooks](https://github.co
| Repo AI workflow files changed (`.codex/**`, `.cursor/**`) | Keep the Codex and Cursor copies aligned when they represent the same workflow; update `AGENTS.md` if the default agent policy changes |
| GitHub operation needed | Use `gh` CLI, not GitHub MCP |
| User asks for commit/issue phrasing | Use `docs/agent-playbooks/commit-issue-format.md` |
| Repo AI workflow files changed (`.codex/**`, `.cursor/**`) | Keep the Codex and Cursor copies aligned when they represent the same workflow |
| Surprising/ambiguous repo behavior encountered | Alert developer and, once confirmed, document in `docs/agent-playbooks/known-surprises.md` |

## Stack
Expand Down
2 changes: 1 addition & 1 deletion test/test-server/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ const plebbitDataPath = getTmpFolderPath();
const comment = await plebbit2.createComment({
title: "comment title",
content: "comment content",
subplebbitAddress: signer.address,
communityAddress: signer.address,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test server uses unsupported property name for plebbit-js

High Severity

The test server calls plebbit2.createComment() directly with communityAddress instead of the original subplebbitAddress. Unlike the application code in accounts-actions.ts, which wraps options through withLegacySubplebbitAddress() to ensure both property names are present, this call goes straight to plebbit-js without the compat layer. Since plebbit-js at the pinned commit hasn't been rebranded (evidenced by createSubplebbit still being used on line 45 and the compat layer's entire existence), it likely doesn't recognize communityAddress, causing test comment publishing to fail silently or error.

Fix in Cursor Fix in Web

signer,
author: { address: signer.address },
});
Expand Down
Loading