Conversation
Introduces a rewrite rule to route all requests to index.html, which is useful for single-page applications using client-side routing.
… arch-specific scripts Updated build-docker.sh to use Electron Forge instead of electron-builder, switched from electronuserland/builder image to node:22, and removed electron-builder-specific commands. Added architecture-specific build scripts (linux:x64, linux:arm64, mac:x64, mac:arm64) to package.json for CI workflow. Removed outdated electron-rebuild comment from release.yml.
Merge pull request #803 from bitsocialhq/development
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on February 8
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| dockerfile=' | ||
| FROM electronuserland/builder:16 | ||
| FROM node:22 |
There was a problem hiding this comment.
Docker build fails due to missing build tools
Medium Severity
The Docker base image changed from electronuserland/builder:16 to node:22. The electronuserland/builder image includes Wine, Mono, and other tools required for cross-platform Electron builds. The plain node:22 image lacks these dependencies, so the Docker-based Windows build (yarn electron:build:windows) will fail when run inside the container because Wine is required to create Windows installers on Linux using @electron-forge/maker-squirrel.
Additional Locations (1)
Merge pull request #808 from bitsocialhq/development
1 participant
Note
Medium Risk
Touches the Electron build/release pipeline and bundled Kubo version, which can affect packaging reliability and runtime behavior across platforms. The UI changes are low risk, but release/build changes are harder to validate without CI artifacts on all targets.
Overview
Electron packaging/build pipeline is updated and standardized around Node 22. The release workflow and
electron/build-docker.shswitch to Node 22-based builds, add explicit per-arch Linux/Mac build scripts, and adjust the docker image/tag naming away from “electron-builder”.Kubo/IPFS bundling is revised. The bundled Kubo version is bumped to
0.39.0inelectron/before-pack.js(with a note to keep it in sync withpackage.json) and the forge config is updated to set per-platform icons for DMG/Squirrel/AppImage.Minor runtime/frontend behavior tweaks.
electron/main.jssets the macOS app name and dock icon on startup,index.htmlavoids hash-redirects forfile://(Electron) loads, andvercel.jsonadds a rewrite to route all paths toindex.html.Small refactor/cleanup. Adds a reusable
useScheduledResethook and migrates “copied” feedback timeouts inErrorDisplayandCommentToolsto it; removesscripts/verify-executable.jsand drops@electron/rebuildfrom dependencies (with corresponding lockfile cleanup).Written by Cursor Bugbot for commit 1914a28. This will update automatically on new commits. Configure here.