Better classpath detection and remove the needs of Java options

[mrsarm]

• Use JavaShellToolBuilder to create the jshell console instead of the internal class JShellToolProvider
  • The change allows to avoid the need to use special java options to run the task
  • Improvements in README doc
• Improve classpath loading
  • Add dependsOn 'classes' only if the task is registered, otherwise let the task without dependencies and warn that the project need to be compiled first (multi-modules projects may not have the :classes task available). Fix issue class net.java.openjdk.shinyafox.jshell.gradle.plugin.JShellGradlePlugin$_apply_closure1 (in unnamed module @0x221924ce) cannot access class jdk.internal.jshell.tool.JShellToolProvider (in module jdk.jshell) because module jdk.jshell does not export jdk.internal.jshell.tool to unnamed module @0x221924ce #6
  • Takes classpath paths from project and subprojects if exist. Also use JavaExec instead of JavaCompile to scan not just the "implementation" dependencies (or "compile") but also scan the "runtimeOnly" dependencies (or "runtime")
  • Add some logging
  • Remove unused imports

[mrsarm]

Hi @bitterfox , did you have the chance to check my PR? Is there something you think need to be fixed first?

[vbrandl]

I would love to see this merged. #6 is currently blocking me from using this plugin.

[mrsarm]

@vbrandl I made a fork a few weeks ago with the patch and other improvements, and is also published in the Gradle plugins center: https://github.com/mrsarm/jshell-plugin

[vbrandl]

@mrsarm thanks for the heads up. I'll look into it at work on Monday.

[bitterfox]

Hi, @mrsarm
Thank you for your contribution and I really apologize that I wasn't aware of your contribution for longer.
I saw your fork on Twitter recently and I noted your pull request.
I really love to see your respectful fork! You improved my PoC project from various aspects, implementations, features, documentation, and a lot! 👍

I'd like to mention/introduce your fork in README, but may I?

Also please tell me how should I handle this PR. I'm welcome to merge this, but I think your code is already used in your fork.
So I respect your preference.

Again, thank you for your contribution and great forks and I really apologize for your inconvenience.

[mrsarm]

Hi @bitterfox , thanks for your comments !

I'd like to mention/introduce your fork in README, but may I?

Sure, please do.

Also please tell me how should I handle this PR. I'm welcome to merge this, but I think your code is already used in your fork.
So I respect your preference.

Yes, if you plan to not maintain this repo anymore there is no need to merge it. Furthermore, in the v1.1.0 of my fork I added changes not reflected here. The most important change is how the task is registered in Gradle, the old way made the plugin not working well with Java 12+.