Chore: Add 'isActive' extension menthods for CipherView and CipherListView#6769
Merged
david-livefront merged 1 commit intomainfrom Apr 7, 2026
Merged
Chore: Add 'isActive' extension menthods for CipherView and CipherListView#6769david-livefront merged 1 commit intomainfrom
david-livefront merged 1 commit intomainfrom
Conversation
github-actions
bot
added
app:password-manager
david-livefront
changed the title
david-livefront
force-pushed
the
add-isActive-cipher-extension
branch
from
7517bfd to
0bc1eb7
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6769 +/- ##
==========================================
+ Coverage 85.33% 85.66% +0.33%
==========================================
Files 957 867 -90
Lines 60714 59783 -931
Branches 8634 8588 -46
==========================================
- Hits 51808 51215 -593
+ Misses 5900 5577 -323
+ Partials 3006 2991 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
New Issues (128)Checkmarx found the following issues in this Pull Request
|
andrebispo5
previously approved these changes
Apr 7, 2026
Contributor
andrebispo5
left a comment
andrebispo5
left a comment
There was a problem hiding this comment.
This is a very good refactor! 🥇
SaintPatrck
added
the
ai-review-vnext
Contributor
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR introduces Code Review DetailsNo findings. The refactoring is straightforward and correctly preserves existing behavior. The remaining |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Comment on lines
+40
to
+50
| @Test | ||
| fun `isActive should return true when item is not archived and is deleted`() { | ||
| val cipherListView = mockk<CipherListView> { | ||
| every { archivedDate } returns null | ||
| every { deletedDate } returns clock.instant() | ||
| } | ||
|
|
||
| assertFalse(cipherListView.isActive) | ||
| } | ||
|
|
||
| @Test |
Contributor
There was a problem hiding this comment.
Details and fix
Line 40: isActive should return true when item is not archived and is deleted asserts assertFalse.
Line 50: isActive should return true when item is archived and is deleted asserts assertFalse.
Both test names should say "return false" to match the actual assertions:
Suggested change
| @Test | |
| fun `isActive should return true when item is not archived and is deleted`() { | |
| val cipherListView = mockk<CipherListView> { | |
| every { archivedDate } returns null | |
| every { deletedDate } returns clock.instant() | |
| } | |
| assertFalse(cipherListView.isActive) | |
| } | |
| @Test | |
| @Test | |
| fun `isActive should return false when item is not archived and is deleted`() { | |
| val cipherListView = mockk<CipherListView> { | |
| every { archivedDate } returns null | |
| every { deletedDate } returns clock.instant() | |
| } | |
| assertFalse(cipherListView.isActive) | |
| } | |
| @Test | |
| fun `isActive should return false when item is archived and is deleted`() { | |
| val cipherListView = mockk<CipherListView> { | |
| every { archivedDate } returns clock.instant() | |
| every { deletedDate } returns clock.instant() | |
| } | |
| assertFalse(cipherListView.isActive) | |
| } |
Misleading test names cause confusion when reading test reports or debugging failures.
Comment on lines
+40
to
+50
| @Test | ||
| fun `isActive should return true when item is not archived and is deleted`() { | ||
| val cipherListView = mockk<CipherView> { | ||
| every { archivedDate } returns null | ||
| every { deletedDate } returns clock.instant() | ||
| } | ||
|
|
||
| assertFalse(cipherListView.isActive) | ||
| } | ||
|
|
||
| @Test |
Contributor
There was a problem hiding this comment.
Details and fix
Suggested change
| @Test | |
| fun `isActive should return true when item is not archived and is deleted`() { | |
| val cipherListView = mockk<CipherView> { | |
| every { archivedDate } returns null | |
| every { deletedDate } returns clock.instant() | |
| } | |
| assertFalse(cipherListView.isActive) | |
| } | |
| @Test | |
| @Test | |
| fun `isActive should return false when item is not archived and is deleted`() { | |
| val cipherListView = mockk<CipherView> { | |
| every { archivedDate } returns null | |
| every { deletedDate } returns clock.instant() | |
| } | |
| assertFalse(cipherListView.isActive) | |
| } | |
| @Test | |
| fun `isActive should return false when item is archived and is deleted`() { | |
| val cipherListView = mockk<CipherView> { | |
| every { archivedDate } returns clock.instant() | |
| every { deletedDate } returns clock.instant() | |
| } | |
| assertFalse(cipherListView.isActive) | |
| } |
david-livefront
force-pushed
the
add-isActive-cipher-extension
branch
from
0bc1eb7 to
ecebb7a
Compare
andrebispo5
approved these changes
Apr 7, 2026
Collaborator
Author
|
Thanks @andrebispo5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
N/A
📔 Objective
This PR adds helper functions for the
CipherVIewandCipherListViewto indicate if the ciphers are still active.Active is indicated by the cipher not being deleted or archived.
No functionality has changed in this PR.