PM-33458: feat: Add speed bump when archiving item from a list#6774
Open
david-livefront wants to merge 1 commit intomainfrom
Open
PM-33458: feat: Add speed bump when archiving item from a list#6774david-livefront wants to merge 1 commit intomainfrom
david-livefront wants to merge 1 commit intomainfrom
Conversation
github-actions
bot
added
app:password-manager
david-livefront
commented
Apr 8, 2026
| } | ||
| when (val option = showConfirmationDialog) { | ||
| is ListingItemOverflowAction.SendAction.DeleteClick -> { | ||
| BitwardenTwoButtonDialog( |
Collaborator
Author
There was a problem hiding this comment.
This is now encapsulated under the speedBump in the overflow action.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6774 +/- ##
==========================================
+ Coverage 85.32% 85.72% +0.40%
==========================================
Files 872 827 -45
Lines 60099 58465 -1634
Branches 8599 8539 -60
==========================================
- Hits 51279 50122 -1157
+ Misses 5828 5387 -441
+ Partials 2992 2956 -36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
New Issues (130)Checkmarx found the following issues in this Pull Request
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @Suppress("MaxLineLength") | ||
| @Test | ||
| fun `on item archive overflow option click should display archive confirmation dialog and emits ArchiveClick on confirmation`() { | ||
| val cipherId = "mockId-1" |
| fun `on vault item archive overflow option click should display archive confirmation dialog and emits ArchiveClick on confirmation`() { | ||
| val itemText = "Test Item" | ||
| val userName = "Bitwarden" | ||
| val cipherId = "12345" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-33458
📔 Objective
This PR adds a speed bump dialog when archiving an item from any of the listing screens.
📸 Screenshots