Skip to content

[PM-36047] Add tech-leads group as owners of the CODEOWNERS file#20435

Merged
coltonhurst merged 1 commit intomainfrom
dn/pm-36047
May 4, 2026
Merged

[PM-36047] Add tech-leads group as owners of the CODEOWNERS file#20435
coltonhurst merged 1 commit intomainfrom
dn/pm-36047

Conversation

@coltonhurst
Copy link
Copy Markdown
Member

@coltonhurst coltonhurst commented Apr 29, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-36047

📔 Objective

For some existing repositories, there is no owner for the CODEOWNERS file itself. This presents a couple of concerns. The main initial concern is that a team’s ownership can change without them knowing or being approvers of the change.

This could be fixed in multiple ways, but two were discussed:

  1. CODEOWNERS changes require approval from all teams whose ownership is changing. This is the better solution, but GitHub doesn’t seem to provide this capability. Something custom would have to be created, so this option is more effort.
  2. CODEOWNERS changes require approval from the Tech Lead group. This is a less ideal solution compared to #1, but it should help provide more approval from the tech lead owners of files, and give them notifications on any changes.

For now, this change goes route #2. We aim to apply these changes only on monorepos. Team specific repositories shouldn't have this change.

@coltonhurst coltonhurst self-assigned this Apr 29, 2026
@coltonhurst coltonhurst changed the title Add tech-leads group as owners of the CODEOWNERS file [PM-36047] Add tech-leads group as owners of the CODEOWNERS file Apr 29, 2026
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.10%. Comparing base (0e2dc87) to head (09c3e12).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20435   +/-   ##
=======================================
  Coverage   47.10%   47.10%           
=======================================
  Files        3930     3930           
  Lines      119287   119287           
  Branches    18302    18302           
=======================================
+ Hits        56190    56192    +2     
+ Misses      58840    58839    -1     
+ Partials     4257     4256    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Detailsfed78d56-bc82-463e-8575-c06d7aa7f78a

Great job! No new security vulnerabilities introduced in this pull request

@coltonhurst coltonhurst marked this pull request as ready for review April 29, 2026 15:43
@coltonhurst coltonhurst requested a review from theMickster April 29, 2026 15:43
@coltonhurst coltonhurst merged commit 58ed7db into main May 4, 2026
54 checks passed
@coltonhurst coltonhurst deleted the dn/pm-36047 branch May 4, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants