Skip to content

PM-29781 initial commit#20437

Draft
bmbitwarden wants to merge 1 commit intomainfrom
PM-29781-Remove-the-feature-flag-for-email-verification-clients
Draft

PM-29781 initial commit#20437
bmbitwarden wants to merge 1 commit intomainfrom
PM-29781-Remove-the-feature-flag-for-email-verification-clients

Conversation

@bmbitwarden
Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-29781

📔 Objective

Remove the feature flag pm-19051-send-email-verification from clients only. and the code behind it

📸 Screenshots

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.12%. Comparing base (f73e2be) to head (fbba781).
⚠️ Report is 34 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../app/tools/send/send-access/send-view.component.ts 0.00% 5 Missing ⚠️
...ols/send/send-access/send-access-file.component.ts 0.00% 2 Missing ⚠️
apps/cli/src/tools/send/send.program.ts 0.00% 1 Missing ⚠️
.../app/tools/send/send-access/send-auth.component.ts 0.00% 1 Missing ⚠️
.../components/send-details/send-details.component.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20437      +/-   ##
==========================================
+ Coverage   47.01%   47.12%   +0.11%     
==========================================
  Files        3912     3930      +18     
  Lines      118440   119162     +722     
  Branches    18117    18267     +150     
==========================================
+ Hits        55681    56157     +476     
- Misses      58571    58758     +187     
- Partials     4188     4247      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Detailsd8a08162-ada9-43c2-9f51-3c1a25998e9c


New Issues (1) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 MEDIUM Insecure_Storage_of_Sensitive_Data apps/cli/src/tools/send/commands/receive.command.ts: 166
detailsThe application takes sensitive, personal data credentials, found at line 166 of /apps/cli/src/tools/send/commands/receive.command.ts, and stores...
Attack Vector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant