Skip to content

[PM-31942] Save Access Intelligence reports to files (pt. 3)#20441

Open
lastbestdev wants to merge 5 commits intodirt/file-persistence-servicefrom
dirt/file-storage-orgreports
Open

[PM-31942] Save Access Intelligence reports to files (pt. 3)#20441
lastbestdev wants to merge 5 commits intodirt/file-persistence-servicefrom
dirt/file-storage-orgreports

Conversation

@lastbestdev
Copy link
Copy Markdown
Contributor

update target branch to main after #20289 merges

🎟️ Tracking

Part 3 of https://bitwarden.atlassian.net/browse/PM-31942

📔 Objective

The last PR for integration of saving Access Intelligence reports as files. Changes include adding a new implementation of the ReportPersistenceService abstraction, solely for the purpose of conditionally choosing to store reports using the old method (database column storage), or the new way (file storage).

The implementation is determined by the value of the newly added feature flag, for using report file storage.

📸 Screenshots

N/A

@lastbestdev lastbestdev requested a review from a team as a code owner April 29, 2026 18:24
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.17%. Comparing base (0a1f0ed) to head (a31fd14).
⚠️ Report is 17 commits behind head on dirt/file-persistence-service.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...mon/src/dirt/access-intelligence/services/index.ts 0.00% 4 Missing ⚠️
...intelligence/access-intelligence-routing.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           dirt/file-persistence-service   #20441      +/-   ##
=================================================================
+ Coverage                          47.12%   47.17%   +0.05%     
=================================================================
  Files                               3938     3949      +11     
  Lines                             119634   119949     +315     
  Branches                           18344    18412      +68     
=================================================================
+ Hits                               56373    56586     +213     
- Misses                             58990    59078      +88     
- Partials                            4271     4285      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

Logo
Checkmarx One – Scan Summary & Details7f586422-448f-4a86-9295-9c888cf89959

Great job! No new security vulnerabilities introduced in this pull request

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant