[PM-31942] Save Access Intelligence reports to files (pt. 3)#20441
Open
lastbestdev wants to merge 5 commits intodirt/file-persistence-servicefrom
Open
[PM-31942] Save Access Intelligence reports to files (pt. 3)#20441lastbestdev wants to merge 5 commits intodirt/file-persistence-servicefrom
lastbestdev wants to merge 5 commits intodirt/file-persistence-servicefrom
Conversation
…torage, based on feature flag value
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dirt/file-persistence-service #20441 +/- ##
=================================================================
+ Coverage 47.12% 47.17% +0.05%
=================================================================
Files 3938 3949 +11
Lines 119634 119949 +315
Branches 18344 18412 +68
=================================================================
+ Hits 56373 56586 +213
- Misses 58990 59078 +88
- Partials 4271 4285 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




update target branch to
mainafter #20289 merges🎟️ Tracking
Part 3 of https://bitwarden.atlassian.net/browse/PM-31942
📔 Objective
The last PR for integration of saving Access Intelligence reports as files. Changes include adding a new implementation of the ReportPersistenceService abstraction, solely for the purpose of conditionally choosing to store reports using the old method (database column storage), or the new way (file storage).
The implementation is determined by the value of the newly added feature flag, for using report file storage.
📸 Screenshots
N/A