Skip to content

[PM-34331] Update electron to 41#20448

Open
dani-garcia wants to merge 3 commits intomainfrom
ps/PM-34331-update-electron
Open

[PM-34331] Update electron to 41#20448
dani-garcia wants to merge 3 commits intomainfrom
ps/PM-34331-update-electron

Conversation

@dani-garcia
Copy link
Copy Markdown
Member

@dani-garcia dani-garcia commented Apr 30, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-34331

📔 Objective

Update electron to version 41 and the rest of the electron updates to their latest patch, which should solve compilation issues with the latest Visual Studio.

I've also had to enable a new fuse from electron 41, but I just set it to the default value so everything should work the same: https://github.com/electron/fuses/blob/bbf079259e66af30858578a1e070575f11c01915/README.md?plain=1#L29

Note that this will cause the desktop app to start using the bundled node 24, the rest of the clients except CLI are updated as part of #20400

I can't get renovate to create the PR right now so I've created it myself instead.

📸 Screenshots

@dani-garcia dani-garcia added the ai-review-vnext Request a Claude code review using the vNext workflow label Apr 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR bumps Electron from 39.8.5 to 41.3.0 (skipping 40) along with the related toolchain (electron-builder 26.8.2 → 26.9.0, electron-updater 6.6.4 → 6.8.3, @electron/notarize 3.0.1 → 3.1.1, @electron/rebuild 4.0.3 → 4.0.4) and the package-lock.json. The previously flagged inconsistency between electron-builder.json and electron-builder.beta.json has been resolved in commit 56d10378 — both configs now pin electronVersion to 41.3.0. The new WasmTrapHandlers fuse introduced in Electron 41 is set in apps/desktop/scripts/after-pack.js and matches the documented default behavior.

Code Review Details

No new findings. The previously raised IMPORTANT finding about apps/desktop/electron-builder.beta.json lagging behind the main config has been addressed.

Dependency Changes

Package Change Ecosystem
electron 39.8.5 → 41.3.0 (major) npm
electron-builder 26.8.2 → 26.9.0 npm
electron-updater 6.6.4 → 6.8.3 npm
@electron/notarize 3.0.1 → 3.1.1 npm
@electron/rebuild 4.0.3 → 4.0.4 npm

Comment thread apps/desktop/electron-builder.json
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.10%. Comparing base (14e9b6a) to head (d0dace9).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20448   +/-   ##
=======================================
  Coverage   47.10%   47.10%           
=======================================
  Files        3941     3941           
  Lines      119681   119681           
  Branches    18371    18371           
=======================================
  Hits        56377    56377           
  Misses      59035    59035           
  Partials     4269     4269           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dani-garcia dani-garcia requested a review from a team as a code owner April 30, 2026 11:59
@dani-garcia dani-garcia requested a review from djsmith85 April 30, 2026 11:59
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant