Skip to content

[PM-21777]Defect Safari - Save login notification bar icon is stretched and Save login is scrollable#20449

Open
dan-livefront wants to merge 2 commits intomainfrom
PM-21777-defect-safari-save-login-notification-bar-styling
Open

[PM-21777]Defect Safari - Save login notification bar icon is stretched and Save login is scrollable#20449
dan-livefront wants to merge 2 commits intomainfrom
PM-21777-defect-safari-save-login-notification-bar-styling

Conversation

@dan-livefront
Copy link
Copy Markdown
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-21777

📔 Objective

The edit button was stretching vertically in Safari which caused the cipher row to extend vertically. Edited styling to avoid this case, additionally, removed typography from here for styling, it is not needed.

📸 Screenshots

Screenshot 2026-04-30 at 10 14 17 AM

@dan-livefront dan-livefront self-assigned this Apr 30, 2026
@dan-livefront dan-livefront added the ai-review Request a Claude code review label Apr 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed a small Safari-specific styling fix to the autofill notification bar's edit button (apps/browser/src/autofill/content/components/buttons/edit-button.ts). The change replaces a padding + max-height: fit-content + overflow: hidden approach with explicit width/height plus flexbox centering, and drops the now-unused typography.helperMedium import for an icon-only button. Resolved values are preserved (border-radius and padding remain 4px; total button size is 24px), the new approach mirrors the sibling close-button.ts pattern, and accessibility (title, aria-label) is unchanged. No security, correctness, performance, or breaking-change concerns identified.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.10%. Comparing base (d287f11) to head (caf60ec).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...autofill/content/components/buttons/edit-button.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20449      +/-   ##
==========================================
- Coverage   47.10%   47.10%   -0.01%     
==========================================
  Files        3943     3943              
  Lines      119797   119800       +3     
  Branches    18388    18388              
==========================================
+ Hits        56432    56433       +1     
- Misses      59090    59093       +3     
+ Partials     4275     4274       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

@dan-livefront dan-livefront marked this pull request as ready for review April 30, 2026 16:31
@dan-livefront dan-livefront requested a review from a team as a code owner April 30, 2026 16:31
@dan-livefront dan-livefront requested a review from blackwood April 30, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant