Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20460 +/- ##
=======================================
Coverage 47.10% 47.10%
=======================================
Files 3949 3949
Lines 119740 119740
Branches 18344 18344
=======================================
+ Hits 56399 56400 +1
+ Misses 59105 59104 -1
Partials 4236 4236 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This fixes memory leaks on async functions and allows us to specify NAPI types in feature crates rather than duplicating them for exporting in @bitwarden/desktop-napi.
iinuwa
force-pushed
the
skunkworks/PM-36068/update-napi
branch
from
2629a0b to
1d657d7
Compare
|
neuronull
approved these changes
May 1, 2026
Contributor
Author
|
CI failure for Windows Beta build is unrelated. Release builds have all passed, so continuing onto QA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-36068
📔 Objective
This fixes memory leaks on async functions and allows us to specify NAPI types in feature crates rather than duplicating them for exporting in @bitwarden/desktop-napi.