Conversation
…gistration start services - just use different translations on Web/Desktop vs Extension
…yout for more accuracy
…es.json so it gets picked up by PreloadedEnglishI18nModule
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #20478 +/- ##
==========================================
- Coverage 47.09% 47.07% -0.02%
==========================================
Files 3949 3954 +5
Lines 119744 119765 +21
Branches 18345 18349 +4
==========================================
- Hits 56393 56385 -8
- Misses 59115 59147 +32
+ Partials 4236 4233 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed a UI refinement that fixes the extension scrollbar issue by introducing per-client component configuration services for Code Review DetailsNo findings. |
| }, | ||
| "receiveMarketingEmailsShort": { | ||
| "message": "Receive updates from Bitwarden in your inbox." | ||
| }, |
There was a problem hiding this comment.
This translations is not used on the Web app, but adding it here so that PreloadedEnglishI18nModule (located in web) works correctly in registartion-start.stories.ts



🎟️ Tracking
PM-32445
📔 Objective
This PR makes design tweaks to 3 pages on the Extension to ensure that a scrollbar does not appear:
/login/login-with-passkey/signupThere are two general "groups" of changes here:
app-routing.module.tsvia route properties (ExtensionAnonLayoutWrapperDataandAnonLayoutWrapperData). These changes effect the anon layout structure of the page (hero and footer sections).📸 Screenshots
Extension -
/loginpage (email entry screen)Extension -
/loginpage (master password entry screen)Extension -
/login-with-passkeypage (reading passkey screen)Extension -
/login-with-passkeypage (failure screen)Extension -
/signupWeb - Smoke Test
This video shows that Web UI remains unchanged (i.e. the Extension changes did not leak to Web)
web-smoke-test.mov