[PM-40440] fix: Source upgrade cart total from server invoice preview

[amorask-bitwarden]

🎟️ Tracking

Resolves PM-40440

📔 Objective

The organization change-plan (upgrade) dialog computed the cart total on the client and re-applied the org's customerDiscount percentage to the newly selected plan. When an organization has an active price-migration schedule, the server surfaces the schedule's Phase 2 migration coupon as customerDiscount, so the dialog under-quoted the upgrade total by the coupon percentage (~20%) and rendered a misleading "provider discount" line. On confirm, the upgrade releases the schedule and drops the coupon, so the customer is charged the full price — the preview under-quoted them. (Display-only; no one was mischarged.)

This change stops computing the total on the client for this dialog and instead renders the Stripe invoice-preview Total the server already returns from the plan-change tax preview (estimatedTotal), falling back to the existing client total getter on error/first paint. The five client-side provider-discount rows and the now-dead discountPercentageFromSub field and calculateTotalAppliedDiscount() helper are removed. The server total applies genuine customer-level discounts but not the schedule coupon, so the quote is correct in both the migration and legitimate-discount cases.

Depends on a companion server fix — should not merge alone. The server plan-change tax preview (PreviewOrganizationTaxCommand) drops Secrets Manager line items across a tier change (it looks up SM seat/service-account prices by the new plan's IDs against the current subscription). Until that lands, sourcing the total from the server would under-quote SM-enabled Teams→Enterprise upgrades. Being handled separately in server.

📸 Screenshots

server PR: bitwarden/server#7995

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the change-plan (upgrade) dialog fix that sources the cart total from the server invoice-preview Total (estimatedTotal) instead of recomputing it client-side and re-applying customerDiscount. Verified the estimatedTotal ?? total fallback in both template total bindings, the new isFromSchedule guard in isSecretsManagerTrial(), the removal of the dead discountPercentageFromSub field / calculateTotalAppliedDiscount() helper / provider-discount rows, and the accompanying response-model change. No security, correctness, or breaking-change issues found.

Code Review Details

No findings.

Notes from the review (no action required):

• isFromSchedule defaults to false via getResponseProperty("IsFromSchedule") ?? false, so the client remains backward-compatible with server responses that predate the companion server fix.
• The removed field, helper, and template rows have no remaining references in the dialog; the providerDiscount i18n key is still used by organization-subscription-cloud.component.html, so no key was orphaned.
• estimatedTotal is cleared on plan switch and on preview error, correctly falling back to the client total getter until the server preview resolves.
• The PR correctly documents its dependency on the companion server PR ([PM-40440] fix: Include Secrets Manager and storage in plan-change tax preview server#7995) and should not merge alone.

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.04%. Comparing base (d022cf1) to head (f907eca).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ling/organizations/change-plan-dialog.component.ts	80.00%	0 Missing and 1 partial ⚠️
...els/response/organization-subscription.response.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #21902      +/-   ##
==========================================
+ Coverage   52.03%   52.04%   +0.01%     
==========================================
  Files        4098     4098              
  Lines      129737   129740       +3     
  Branches    20350    20350              
==========================================
+ Hits        67514    67529      +15     
+ Misses      57234    57206      -28     
- Partials     4989     5005      +16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.