[PM-26293] tool: Add scripts to delete duplicate Localizable.strings entries

[KatherineInCode]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26293

📔 Objective

This is inspired by, and solves, the issue brought up in #2004, in addition to making it easier to avoid that same sort of issue in the future.

This introduces a modular python script that can be used to "fix" our Localizable.strings files; long-term, it may make sense to run this as a pre-commit hook as well. Currently, the one module introduced handles duplicate entries in the strings files; I intend in a future PR to include a module for unused entries, and then potentially a module for alphabetization, among other things. These all live under the Scripts/fix-localizable-strings directory.

As well, there is a Scripts/fix-localizable-strings.sh script that invokes the Python script against the various localizable files. As the modules expand, it can also handle doing those. This would be what the pre-commit hook would run.

Finally, there is a Scripts/test-fix-localizable-strings.sh that is an easy invocation of running the tests for the fix-localizable-strings Python script (which currently just tests the duplication work. In the future, we may consider adding the running of these to CI.

One last thing: one of the duplicated strings ("SendUpdated") had two different strings for the key. I ended up choosing the one that matches what I could find in Figma.

[claude]

Claude finished @KatherineInCode's task in 3m 8s —— View job

---

Re-review: PM-26293 Add scripts to delete duplicate localizable.strings entries

• Scope to incremental changes since last review (276d137)
• Verify prior findings are addressed
• Check for new issues in changed code

Incremental Changes (commits d94fe47, 3d547b8, 43c2ae6, fdf096d)

These four commits address all prior review feedback:

Commit	Change	Assessment
43c2ae67f	Block comment detection changed from "/*" in stripped to stripped.startswith("/*")	Correctly fixes the prior WARNING finding. Entry lines always start with " after stripping, so startswith("/*") cleanly excludes them without needing the reorder approach originally suggested.
3d547b83b	Added TestDeduplicateEntryValueContainingCommentSyntax with two tests	Directly covers the edge case from the prior finding (/* in values, */ in later values).
fdf096db9	Docstrings to Google-style, type annotations on _pluralize/cmd_delete_duplicates, sys.exit(1) on missing subcommand	All improvements: Python-conventional docstrings, better type safety, correct CLI exit behavior.
d94fe47e3	.gitignore comment clarifying source URL	Documentation-only.

Prior Findings Status

Finding	Status
WARNING: "/*" in stripped misidentifies entry values as block comments	Resolved -- fixed via startswith("/*") with regression tests added

Verdict

No new issues found. All prior feedback has been addressed cleanly. The PR is in good shape.

[github-actions]

Checkmarx One – Scan Summary & Details – e6197ff4-bbce-4c50-bfa1-ad57b03a70b4

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.95%. Comparing base (a83e8f1) to head (c7e36b6).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2412      +/-   ##
==========================================
- Coverage   87.08%   85.95%   -1.13%     
==========================================
  Files        1862     2092     +230     
  Lines      165404   180212   +14808     
==========================================
+ Hits       144040   154900   +10860     
- Misses      21364    25312    +3948     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[matt-livefront]

🎨 Is it worth documenting at the top of the file here what this script does? I've found that to be helpful when looking at other scripts that we have.

[KatherineInCode]

Good call. Updated.

[matt-livefront]

🎨 Same thing here, worth documenting what this does?

[github-actions]

Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds a modular Python script for removing duplicate entries from Localizable.strings files, shell wrappers for execution and testing, and applies the deduplication to the English Localizable.strings file (removing 5 duplicates and correcting the SendUpdated value to match Figma). The latest commits add header comments to the shell scripts, addressing reviewer feedback. Test coverage is thorough with 368 lines across 8 test classes.

Code Review Details

No findings. Prior review feedback has been fully addressed:

Prior Finding	Status
WARNING: "/*" in stripped misidentifies entry values as block comments	Resolved via startswith("/*") with regression tests added