Skip to content

Comments

[BRE-1437] Testing shellcheck on BW lite scripts#445

Closed
pixman20 wants to merge 1 commit intomainfrom
BRE-1437-add-shellcheck-test-for-bitwarden-lite-entrypoint-sh
Closed

[BRE-1437] Testing shellcheck on BW lite scripts#445
pixman20 wants to merge 1 commit intomainfrom
BRE-1437-add-shellcheck-test-for-bitwarden-lite-entrypoint-sh

Conversation

@pixman20
Copy link
Collaborator

@pixman20 pixman20 commented Dec 22, 2025

🎟️ Tracking

BRE-1437

📔 Objective

Testing shellcheck on BW lite scripts

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsd55258a1-ae45-48a8-85f7-514ab3281ea3

Great job! No new security vulnerabilities introduced in this pull request

@pixman20 pixman20 added the hold Hold this PR or item until later; DO NOT MERGE label Dec 22, 2025
@pixman20
Copy link
Collaborator Author

pixman20 commented Jan 5, 2026

Closing in favor of: #449

@pixman20 pixman20 closed this Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold Hold this PR or item until later; DO NOT MERGE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant