Skip to content

Conversation

@MGibson1
Copy link
Member

📔 Objective

Scenes should return resulting data in the result object The result is for data that cannot be known by the client requesting the scene and the mangle map used for mangling input values to enable parallelizing tests

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

The result is for data that cannot be known by the client requesting the scene and the mangle map used for mangling input values to enable parallelizing tests
Copy link
Contributor

@theMickster theMickster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request to keep
Nevermind... I was incorrect in my assessment of the UserData struct when it came to my changes in #6896.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

Logo
Checkmarx One – Scan Summary & Detailsd956d378-6690-4e84-b892-4d08da39679d

Great job! No new security vulnerabilities introduced in this pull request

theMickster
theMickster previously approved these changes Jan 27, 2026
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.10%. Comparing base (2a45880) to head (ba41d43).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6909      +/-   ##
==========================================
+ Coverage   56.08%   56.10%   +0.01%     
==========================================
  Files        1968     1968              
  Lines       86974    87003      +29     
  Branches     7748     7750       +2     
==========================================
+ Hits        48783    48816      +33     
+ Misses      36385    36379       -6     
- Partials     1806     1808       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MGibson1 MGibson1 merged commit edf694b into main Jan 27, 2026
42 checks passed
@MGibson1 MGibson1 deleted the arch/return-values-for-single-user-scene branch January 27, 2026 20:55
MGibson1 added a commit to bitwarden/clients that referenced this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants