-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Use Scene result for SingleUserScene #6909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The result is for data that cannot be known by the client requesting the scene and the mangle map used for mangling input values to enable parallelizing tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small request to keep
Nevermind... I was incorrect in my assessment of the UserData struct when it came to my changes in #6896.
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6909 +/- ##
==========================================
+ Coverage 56.08% 56.10% +0.01%
==========================================
Files 1968 1968
Lines 86974 87003 +29
Branches 7748 7750 +2
==========================================
+ Hits 48783 48816 +33
+ Misses 36385 36379 -6
- Partials 1806 1808 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|

📔 Objective
Scenes should return resulting data in the result object The result is for data that cannot be known by the client requesting the scene and the mangle map used for mangling input values to enable parallelizing tests
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes