Skip to content

Conversation

@itsadrago
Copy link
Contributor

@itsadrago itsadrago commented Jan 29, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-31394

📔 Objective

The email address used to obtain an email OTP for a send that uses email verification is being rejected by the identity server. The reason is because the identity server is using the plain text email address value against a list of hashed email addresses during the auth process

This change is related to the recent changes that the Tools Team made to ensure that we were not storing email lists in plain text on the server side for the send access feature

📸 Screenshots

This is a successful walkthrough of the email verification feature on my local dev env after the fix in this PR...

email_verification_example.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@itsadrago itsadrago requested review from a team as code owners January 29, 2026 04:27
@itsadrago itsadrago requested a review from enmande January 29, 2026 04:27
@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2026

Logo
Checkmarx One – Scan Summary & Detailsa70fe2a0-219c-4275-9814-462bdbd7ca7c

Great job! No new security vulnerabilities introduced in this pull request

mcamirault
mcamirault previously approved these changes Jan 29, 2026
@itsadrago
Copy link
Contributor Author

There are a few tests still failing. Am working on fixing them today

@Patrick-Pimentel-Bitwarden
Copy link
Contributor

Would you mind putting in your description a recording of the send functionality that has been changed still working?

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.06%. Comparing base (7855c4e) to head (0caa524).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6921      +/-   ##
==========================================
- Coverage   56.06%   56.06%   -0.01%     
==========================================
  Files        1969     1969              
  Lines       87065    87067       +2     
  Branches     7755     7755              
==========================================
- Hits        48817    48813       -4     
- Misses      36439    36446       +7     
+ Partials     1809     1808       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@itsadrago itsadrago merged commit 0544ec4 into main Jan 29, 2026
56 of 57 checks passed
@itsadrago itsadrago deleted the tools/pm-31394/send-access-email-verification-fix branch January 29, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants