Fixed invalid syntax in OrganizationUser_UpdateMany

[mkincaid-bw]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/DBOPS-80

📔 Objective

We found invalid SQL syntax in the OrganizationUser_UpdateMany stored procedure. Oddly, the invalid syntax does not throw an error, but it also does not perform the expected action.

    EXEC [dbo].[User_BumpManyAccountRevisionDates]
    (
        SELECT [UserId]
        FROM @OrganizationUserInput
    )

This code does not actually call User_BumpManyAccountRevisionDates, but instead simply returns the results of the SELECT statement within the parameters. I'm assuming why this has not been noticed before. This PR fixes the invalid syntax, and now the resulting call to User_BumpManyAccountRevisionDates should work as expected.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.00%. Comparing base (93a28ee) to head (91f439d).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6923      +/-   ##
==========================================
+ Coverage   56.08%   60.00%   +3.92%     
==========================================
  Files        1971     1971              
  Lines       87090    87090              
  Branches     7759     7759              
==========================================
+ Hits        48841    52260    +3419     
+ Misses      36441    32935    -3506     
- Partials     1808     1895      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Checkmarx One – Scan Summary & Details – 885a7052-74f3-4068-a9c7-31f87b231400

Great job! No new security vulnerabilities introduced in this pull request