Skip to content

Seeder/add parameterized org seeding#7987

Open
nthompson-bitwarden wants to merge 6 commits into
mainfrom
seeder/add-parameterized-org-seeding
Open

Seeder/add parameterized org seeding#7987
nthompson-bitwarden wants to merge 6 commits into
mainfrom
seeder/add-parameterized-org-seeding

Conversation

@nthompson-bitwarden

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/QA-2074

📔 Objective

Extend SingleOrganizationScene so seeded organizations can override plan-default capability flags (SSO, groups, SCIM, etc...) and set billing gateway identity (gateway, gatewayCustomerId, gatewaySubscriptionId), so that the SeederApi can produce orgs that resemble billed configurations

@nthompson-bitwarden nthompson-bitwarden added the t:tech-debt Change Type - Tech debt label Jul 15, 2026
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the extension of SingleOrganizationScene to support plan-default capability flag overrides (OrganizationOverrides) and billing gateway identity (ApplyBilling). The new override and billing application logic follows the existing null-coalescing pattern already used for collection-management settings, is well covered by unit and integration tests, and the README documentation accurately reflects the numeric enum serialization contract. Changes are confined to the util/Seeder and test/ dev/test surface with no impact on production code paths.

Code Review Details

No findings. The change consistently reuses established seeder conventions:

  • ApplyOrganizationOverrides and ApplyBilling mirror the existing ?? org.X override pattern.
  • Test coverage exercises null, partial, enable-on-default, disable-plan-default, and billing set/preserve cases plus an end-to-end integration test.
  • ExceptionInvalidOperationException in the scene is a small improvement.
  • README enum values verified accurate (gateway: 0 = Stripe, planType: 0 = Free).

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.11%. Comparing base (ac18ce9) to head (8fc0c4e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7987      +/-   ##
==========================================
+ Coverage   62.08%   62.11%   +0.03%     
==========================================
  Files        2284     2284              
  Lines       99724    99666      -58     
  Branches     9016     9016              
==========================================
- Hits        61911    61910       -1     
+ Misses      35638    35576      -62     
- Partials     2175     2180       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant