Skip to content

[PM-40006] Add temporary item sharing feature flag#7996

Open
mcamirault wants to merge 1 commit into
mainfrom
tools/pm-40006/temporary-item-sharing-feature-flag
Open

[PM-40006] Add temporary item sharing feature flag#7996
mcamirault wants to merge 1 commit into
mainfrom
tools/pm-40006/temporary-item-sharing-feature-flag

Conversation

@mcamirault

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-40006

📔 Objective

This PR adds a feature flag that will be used for the Temporary Item Sharing feature

@mcamirault
mcamirault requested a review from a team July 16, 2026 18:04
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the addition of a single feature flag constant TemporaryItemSharing (pm-34203-temporary-item-sharing) to src/Core/Constants.cs. The change follows the established naming convention (PascalCase C# name, pm-XXXXX-kebab-case string value) and is correctly placed in the Tools team section alongside the other Send/sharing flags. No security, correctness, or breaking-change concerns; feature flag constants are not unit-tested and this one introduces no behavior.

Code Review Details

No findings. This is a clean, low-risk change.

@harr1424 harr1424 added the t:feature Change Type - Feature Development label Jul 16, 2026
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.23%. Comparing base (3e79593) to head (6e5ca6d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7996   +/-   ##
=======================================
  Coverage   62.23%   62.23%           
=======================================
  Files        2287     2287           
  Lines       99663    99663           
  Branches     9004     9004           
=======================================
  Hits        62023    62023           
  Misses      35469    35469           
  Partials     2171     2171           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants