Fx login UI#29
Conversation
Note: that i have not created a signup page/I've just provided a linking to it. if the page does not exist, it can be created later or integrated in the login page so that it switches between the two
|
@the1Riddle is attempting to deploy a commit to the bkoimett's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hello @bkoimett , Would you take a moment to review this? thanks |
There was a problem hiding this comment.
AI Code Review by LlamaPReview
🎯 TL;DR & Recommendation
Recommendation: Approve with suggestions
This PR re-routes the root to the login page and adds a placeholder signup route, but introduces a minor routing inefficiency and a potential UX nuance on the signup page.
💡 Suggestions (P2)
- client/src/App.jsx: The redirect from
/loginto/introduces an unnecessary double redirect when unauthenticated users are sent fromProtectedRouteto/login, adding minor complexity and performance overhead. - client/src/pages/LoginPage.jsx: Authenticated users clicking the 'Sign up' link are immediately redirected to
/dashboardwithout seeing the placeholder message, creating a potentially confusing experience.
💡 Have feedback? We'd love to hear it in our GitHub Discussions.
✨ This review was generated by LlamaPReview Advanced, which is free for all open-source projects. Learn more.
bkoimett
left a comment
There was a problem hiding this comment.
fix the issues in teh bot review
|
kept the initial routing, |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
What I changed
Updated routing so root now serves login:
Also added signup entry points without creating a separate signup page file:
The login page is updated such that authenticated users are sent to /dashboard.
fixes: #16