OTWO-7630 Implement BDSA Page Design and SEO

[bd-vaibhav]

No description provided.

[Copilot]

Pull request overview

This pull request updates the BDSA (Black Duck Security Advisories) vulnerability UI to introduce a redesigned landing/show experience with improved SEO metadata, structured data (JSON-LD) markup, updated cookie/terms gating behavior, and substantial styling/UX updates.

Changes:

• Adds a BDSA landing page experience in the vulnerability layout, plus theme toggle and updated search UX (header/landing/mobile).
• Introduces SEO metadata (title/description/canonical/keywords) and JSON-LD schema generation via a new service and helper methods.
• Updates cookie disclaimer flow to gate show-page content behind acceptance, including AJAX-based content loading after acceptance.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
test/controllers/api/vulnerabilities_controller_test.rb	Updates expectations for the new disclaimer-gated placeholder behavior and adds an index route check.
config/locales/vulnerabilities.en.yml	Adds BDSA-specific landing/show/shared copy used for SEO and UI text.
app/views/layouts/vulnerability.html.haml	Major layout redesign: SEO/meta tags, JSON-LD injection, new header/search UI, landing page markup, and disclaimer-gated yielding.
app/views/cookies/_bdsa_disclaimer.html.haml	Redesigns the terms/disclaimer modal content and CTA markup.
app/views/api/vulnerabilities/show.html.haml	Adjusts show-page header and responsive grid sizing.
app/views/api/vulnerabilities/no_data.html.haml	Updates no-data messaging and styling hooks.
app/views/api/vulnerabilities/_cve.html.haml	Updates responsive column sizing for CVE panel.
app/views/api/vulnerabilities/_bdsa.html.haml	Updates responsive column sizing for BDSA panel.
app/services/bdsa_schema_service.rb	Adds a dedicated service to build JSON-LD schema for landing and vulnerability pages.
app/helpers/api/vulnerabilities_helper.rb	Adds helper methods to render the JSON-LD schema generated by the new service.
app/controllers/api/vulnerabilities_controller.rb	Adds an index action and refactors show to support SEO metadata and shared fetch logic.
app/assets/stylesheets/api/custom.sass	Large styling update for the new landing/header/modal/theme/no-data UI.
app/assets/javascripts/api/vulnerability.js.coffee	Adds theme toggle, new search handlers, mobile search toggle, and AJAX content loading after disclaimer acceptance.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

app/assets/javascripts/api/vulnerability.js.coffee:207

• In BdsaCookieConsent.init, when bdsaVisitedCount >= 35 you delete the cookie but the click handler still checks the original bdsaCookiesAllowed value captured at init time, so users won’t be able to accept/continue. Consider checking Cookies.get(...) at click-time (or resetting bdsaCookiesAllowed after deletion) and use a consistent deletion API (e.g., Cookies.remove('bdsa_cookie_disclaimer', { path: '/' })) instead of cookieStore.delete, which may be undefined/unsupported.

  init: () ->
    bdsaCookiesAllowed = Cookies.get('bdsa_cookie_disclaimer')
    if bdsaCookiesAllowed
      bdsaVisitedCount = parseInt(bdsaCookiesAllowed)
      if bdsaVisitedCount < 35
        Cookies.set 'bdsa_cookie_disclaimer', bdsaVisitedCount + 1, { path: '/' }
      else
        cookieStore.delete('bdsa_cookie_disclaimer')
        $('#bdsa_disclaimer_cookies').show()
    $('.bdsa_disclaimer_accept').on 'click', (e) ->
      BdsaCookieConsent.set() unless bdsaCookiesAllowed

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.