OTWO-7638 Add performance findings for admin dashboard#1903
Open
kaushak-ai wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates admin dashboard stats queries and chart generation to reduce query cost (avoiding join-induced duplicates, reducing grouping work, and improving index usage) while adding defensive handling for missing/zero baselines in percentage calculations.
Changes:
- Replaces join+
distinct.sizepatterns withEXISTS-based counting for “projects with enlistments” stats (and caches the results). - Updates dashboard helper percentage methods to avoid divide-by-zero and normalizes cached values to integers.
- Refactors admin project chart monthly gap filling to precompute monthly totals and avoid repeated per-month queries; also adjusts date filtering to avoid
DATE(created_at)casts.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| lib/tasks/admin_project_stats.rake | Changes how “active projects (with enlistments)” is counted and cached. |
| app/helpers/dashboard_helper.rb | Updates cached counts and percentage calculations (including divide-by-zero handling). |
| app/decorators/oh_admin/project_chart.rb | Refactors monthly chart total calculation and simplifies grouped queries. |
| app/decorators/oh_admin/account_chart.rb | Replaces DATE(created_at) predicate with range-friendly timestamp comparison. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This document outlines the performance issues identified in the admin dashboard, including N+1 queries, expensive window-function job lookups, and missing indexes. Recommendations for optimization are provided, along with a caching strategy and validation plan to measure improvements.