OTWO-7663 people/org entire page ui changes#1904
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates People/Organization-related pages and several settings pages to a more modern card-based UI, while improving accessibility (ARIA labels, alt text) and dark-mode chart watermark behavior across the site.
Changes:
- Refactors multiple views (organizations, accounts, stacks, kudos, settings pages) to use updated layouts/components (e.g.,
.oh-card, new “about” expandable cards, updated button sizes). - Improves accessibility by adding missing
alttext, ARIA labels, and improving pagination/alert semantics. - Updates chart watermark handling for dark mode (CSS + JS coordination) and removes some inline watermark styles from chart configs.
Reviewed changes
Copilot reviewed 117 out of 117 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| test/controllers/organizations_controller_test.rb | Updates selector expectation for org summary markup changes. |
| config/locales/organizations.en.yml | Adds new strings for updated org management/table headers. |
| config/locales/en.yml | Updates API key daily limit markup to use a CSS class instead of inline style. |
| config/charting/combined_commit_history.yml | Removes inline chart background watermark styling. |
| config/application.rb | Adjusts default response headers (adds Private Network header). |
| app/views/vulnerabilities/_vulnerability_table.html.haml | Adds alt text for loader image. |
| app/views/stacks/show.html.haml | Updates stacks show layout/buttons and form markup. |
| app/views/stacks/index.html.haml | Updates stacks index button sizing and card styling. |
| app/views/stacks/_stack_entry.html.haml | Updates remove button sizing. |
| app/views/stack_widgets/_widget.html.haml | Adjusts widget form markup and styles wrapper class. |
| app/views/stack_widgets/_promo.html.haml | Adds card styling class to promo container. |
| app/views/stack_widgets/_normal_inner.html.haml | Adds alt text to widget logo image. |
| app/views/stack_widgets/_normal_css.html.haml | Enhances widget icon layout styling (flex + sizing). |
| app/views/stack_entries/_modal.html.haml | Adds alt text to spinner image. |
| app/views/shared/_modern_pagination.html.haml | Adds ARIA labels and hides chevron icons from assistive tech. |
| app/views/shared/_alert.html.haml | Replaces alert markup with modern structure and close button. |
| app/views/scan_analytics/_index.html.haml | Adds alt text to loader image. |
| app/views/reviews/index.html.haml | Wraps header text in <strong> for updated typography. |
| app/views/reviews/_review_list.html.haml | Adjusts grid column sizes and spacing. |
| app/views/reviews/_rater.html.haml | Adds alt text to spinner image. |
| app/views/reviews/_buttons.html.haml | Updates icon button sizes/types for reviews actions. |
| app/views/projects/show/_quick_reference.html.haml | Adds alt text to spinner image. |
| app/views/project_widgets/users.html.haml | Adds alt text to widget logos. |
| app/views/project_widgets/users_logo.html.haml | Adds alt text to widget logo image. |
| app/views/project_widgets/languages.html.haml | Adds alt text to analysis image. |
| app/views/project_widgets/factoids.html.haml | Adds alt text to widget images. |
| app/views/project_widgets/factoids_stats.html.haml | Adds alt text to images and sparkline. |
| app/views/project_widgets/basic_stats.html.haml | Adds alt text to sparkline image. |
| app/views/project_widgets/_ohloh_code_footer.html.haml | Adds alt text to footer logo. |
| app/views/project_widgets/_footer.html.haml | Adds alt text to footer logo. |
| app/views/project_tags/index.html.haml | Adds alt text to spinners. |
| app/views/project_badges/_new_badge_form.html.haml | Adds alt text for badge preview image. |
| app/views/privacy/edit.html.haml | Refactors privacy settings page header/layout and form labels. |
| app/views/privacy/_privacy_text.html.haml | Converts privacy “about” section to expandable card layout. |
| app/views/positions/index.html.haml | Adds card styling and updates button sizing. |
| app/views/positions/_edit_link.html.haml | Updates edit link button style classes. |
| app/views/positions/_commits_by_projects_extended.html.haml | Updates chart container styling/width handling. |
| app/views/positions/_commits_by_individual_projects.html.haml | Adds card styling to project blocks. |
| app/views/positions/_commits_by_individual_project_highchart.html.haml | Updates chart classes for watermark handling and sizing. |
| app/views/permissions/show.html.haml | Refactors layout and converts “about permissions” into expandable card. |
| app/views/people/_unclaimed_person.html.haml | Changes hidden checkbox submission to hidden input. |
| app/views/organizations/show/_portfolio_projects.html.haml | Adds activity column ARIA label and adjusts table header markup. |
| app/views/organizations/show/_outside_projects.html.haml | Adds ARIA label for activity header column. |
| app/views/organizations/show/_outside_committers.html.haml | Updates desktop table header markup and mobile card layout. |
| app/views/organizations/show/_affiliated_committers.html.haml | Updates desktop table header markup and mobile card layout. |
| app/views/organizations/show.html.haml | Adds alt text to loading spinner image. |
| app/views/organizations/new_manager.html.haml | Refactors new manager page layout and form classes. |
| app/views/organizations/list_managers.html.haml | Refactors managers list layout/cards and button sizes. |
| app/views/organizations/edit.html.haml | Refactors org edit layout and adds expandable “about” card wrapper. |
| app/views/organizations/_manage_projects_header.html.haml | Adds ARIA labels/scope for header columns. |
| app/views/organizations/_fields.html.haml | Refactors org form to Bootstrap-ish form-group/input-group structure. |
| app/views/organizations/_about_managers.html.haml | Converts “about managers” content into expandable card. |
| app/views/organizations/_about_basics.html.haml | Refactors “about basics” content layout columns. |
| app/views/organization_widgets/_footer.html.haml | Adds alt text to widget logo. |
| app/views/managers/_new_button.html.haml | Changes layout wrapper and button sizing. |
| app/views/logos/new.html.haml | Refactors logos page layout and about section placement. |
| app/views/logos/_fields.html.haml | Adds ARIA labels and alt text; updates button elements/classes. |
| app/views/logos/_about_organization_logos.html.haml | Converts org logos “about” to expandable card. |
| app/views/logos/_about_logos.html.haml | Converts project logos “about” to expandable card. |
| app/views/kudos/index.html.haml | Replaces kudos index layout with two-card grid design. |
| app/views/kudos/_received.html.haml | Refactors received kudos markup into modern list item layout. |
| app/views/kudos/_given.html.haml | Refactors given kudos markup into modern list item layout. |
| app/views/home/_compact_project_card.html.haml | Adds alt text to account avatar image. |
| app/views/enlistments/_fields.html.haml | Adds alt text to spinner image. |
| app/views/enlistments/_enlistment.html.haml | Uses safe navigation for fis_code_location access. |
| app/views/edits/index_organization.html.haml | Refactors edit history page header and “about” section into card. |
| app/views/edits/index_account.html.haml | Refactors edit history page “about” section into card. |
| app/views/edits/_undo_block.html.haml | Updates button sizing classes for undo/redo actions. |
| app/views/edits/_index.html.haml | Moves search dingus above table; adds alt to spinner. |
| app/views/duplicates/_fields.html.haml | Adds alt text to spinner. |
| app/views/contributions/show/_activity.html.haml | Adds alt text to avatar and sparkline images. |
| app/views/contributions/_contributions.html.haml | Adds alt text to sparkline images. |
| app/views/commits/_commit.html.haml | Adds alt text to spinner image. |
| app/views/api_keys/index.html.haml | Refactors page header and “about” section into expandable card. |
| app/views/api_keys/_form.html.haml | Refactors API key form markup, labels, buttons, and about section. |
| app/views/analyses/_analysis_graphs.html.haml | Adds watermark URLs as data attributes for theme-aware charts. |
| app/views/alter_passwords/edit.html.haml | Refactors password edit page + converts about section to card. |
| app/views/aliases/_fields.html.haml | Adds alt text to spinner image. |
| app/views/accounts/show/header/_kudo_button.html.haml | Updates undo-kudo button icon to inline SVG. |
| app/views/accounts/show/_header.html.haml | Adds alt text to account avatar. |
| app/views/accounts/show/_admin.html.haml | Adds ARIA label and hides icon from assistive tech. |
| app/views/accounts/languages/_commits_by_language.html.haml | Adds watermark data attributes for streamgraph container. |
| app/views/accounts/index.html.haml | Wraps modern pagination in .people-pagination container. |
| app/views/accounts/edit.html.haml | Refactors account edit labels/inputs and adds expandable about card. |
| app/views/accounts/_mini_header.html.haml | Adds alt text to avatar image. |
| app/views/accounts/_account.html.haml | Adjusts separator dot markup for accessibility. |
| app/helpers/site_features_helper.rb | Refactors long HTML string into concatenated Ruby strings. |
| app/helpers/kudos_helper.rb | Updates kudos delete link markup and introduces undo SVG helper. |
| app/helpers/avatar_helper.rb | Adds alt text to generated avatar images. |
| app/decorators/chart_decorator.rb | Strips watermark-related inline background styles after merging configs. |
| app/assets/stylesheets/widgets.sass | Removes label padding rules under widget forms. |
| app/assets/stylesheets/streamgraph.sass | Changes dark-mode watermark handling to pseudo-element overlays. |
| app/assets/stylesheets/stacks.sass | Adds new stack/widget form styling and recommendations tweaks. |
| app/assets/stylesheets/rest_in_place.sass | Adjusts helper link colors and adds dark-mode styles. |
| app/assets/stylesheets/projects.sass | Adjusts settings page header margin behavior. |
| app/assets/stylesheets/privacy.sass | Refactors to modern CSS syntax + adds dark-mode styling. |
| app/assets/stylesheets/positions.sass | Removes fixed widths/backgrounds and adjusts spacing. |
| app/assets/stylesheets/passwords.sass | Adds styles for alter-password layout and dark-mode inputs. |
| app/assets/stylesheets/page.sass | Expands modern alert styling and alignment tweaks. |
| app/assets/stylesheets/orgs.sass | Adjusts typography colors/margins for org UI cards. |
| app/assets/stylesheets/ohloh_suggests.sass | Updates recommendations styling and dark-mode text color. |
| app/assets/stylesheets/kudo_mantle.sass | Adds extensive styling for kudos buttons, modal, and kudos grid. |
| app/assets/stylesheets/home.sass | Tweaks subtitle/button colors. |
| app/assets/stylesheets/grid.sass | Updates .soft text color. |
| app/assets/stylesheets/edits.sass | Tweaks info text colors and adds dark-mode override. |
| app/assets/stylesheets/dark_theme.sass | Updates dark-mode watermark handling for charts and some link colors. |
| app/assets/stylesheets/charts.sass | Updates watermark background styles and includes #all_projects. |
| app/assets/stylesheets/buttons.sass | Updates disabled/variant button colors and shadows. |
| app/assets/stylesheets/api_keys.sass | Adds form styling and dark-mode overrides for API key pages. |
| app/assets/stylesheets/accounts/show.sass | Adjusts header timestamp colors and various typographic colors. |
| app/assets/stylesheets/accounts/edit.sass | Adds comprehensive styling for account edit and expandable about cards. |
| app/assets/stylesheets/account.sass | Adds pagination spacing and tweaks people-card colors/spacing. |
| app/assets/javascripts/upload.js.coffee | Adds ARIA label to the file picker button. |
| app/assets/javascripts/type_ahead.js.coffee | Adds ARIA label to Chosen search inputs on chosen:ready. |
| app/assets/javascripts/contributors_cards.js | Enables expand/collapse toggling for about-account-basics cards. |
| app/assets/javascripts/charts.js | Updates watermark behavior for dark mode and theme toggling. |
| app/assets/javascripts/application.js.coffee | Updates flash close behavior to remove nearest alert/wrapper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.