Skip to content

Skip gateway error codes in IIS shortnames detection#3034

Merged
liquidsec merged 1 commit into3.0from
fix-iis-shortnames-gateway-fp
Apr 14, 2026
Merged

Skip gateway error codes in IIS shortnames detection#3034
liquidsec merged 1 commit into3.0from
fix-iis-shortnames-gateway-fp

Conversation

@liquidsec
Copy link
Copy Markdown
Contributor

Summary

  • Skip 502/503/504 gateway error codes in iis_shortnames.detect() — these come from CDNs and reverse proxies, not IIS, and were causing false positives on CDN-fronted non-IIS hosts
  • Add negative test confirming no FINDING is emitted when the server returns 502

CDNs and reverse proxies return 502/503/504 for upstream failures, not
as an IIS shortname signal. Treating them as status-code differences
caused false positives on CDN-fronted non-IIS hosts.
@github-actions
Copy link
Copy Markdown
Contributor

📊 Performance Benchmark Report

Comparing 3.0 (baseline) vs fix-iis-shortnames-gateway-fp (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 4.24ms 4.25ms +0.3%
Bloom Filter Large Scale Dns Brute Force 17.44ms 17.63ms +1.1%
Large Closest Match Lookup 333.40ms 355.74ms +6.7%
Realistic Closest Match Workload 178.97ms 188.40ms +5.3%
Event Memory Medium Scan 1781 B/event 1781 B/event -0.0%
Event Memory Large Scan 1768 B/event 1768 B/event +0.0%
Event Validation Full Scan Startup Small Batch 370.39ms 369.66ms -0.2%
Event Validation Full Scan Startup Large Batch 526.65ms 520.86ms -1.1%
Make Event Autodetection Small 25.57ms 25.61ms +0.2%
Make Event Autodetection Large 255.67ms 257.72ms +0.8%
Make Event Explicit Types 10.85ms 10.83ms -0.1%
Excavate Single Thread Small 3.451s 3.492s +1.2%
Excavate Single Thread Large 8.688s 8.734s +0.5%
Excavate Parallel Tasks Small 3.660s 3.662s +0.1%
Excavate Parallel Tasks Large 6.791s 6.817s +0.4%
Is Ip Performance 3.12ms 3.18ms +1.8%
Make Ip Type Performance 11.29ms 11.18ms -1.0%
Mixed Ip Operations 4.44ms 4.48ms +0.9%
Memory Use Web Crawl 46.0 MB 46.0 MB +0.0%
Memory Use Subdomain Enum 19.4 MB 19.4 MB +0.0%
Scan Throughput 100 7.984s 8.337s +4.4%
Scan Throughput 1000 39.286s 37.471s -4.6%
Typical Queue Shuffle 61.14µs 61.84µs +1.1%
Priority Queue Shuffle 714.62µs 697.66µs -2.4%

🎯 Performance Summary

No significant performance changes detected (all changes <10%)


🐍 Python Version 3.11.15

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91%. Comparing base (39b9d31) to head (c8d9758).
⚠️ Report is 11 commits behind head on 3.0.

Files with missing lines Patch % Lines
..._step_2/module_tests/test_module_iis_shortnames.py 94% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             3.0   #3034   +/-   ##
=====================================
+ Coverage     91%     91%   +1%     
=====================================
  Files        440     440           
  Lines      37411   37430   +19     
=====================================
+ Hits       33890   33908   +18     
- Misses      3521    3522    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liquidsec liquidsec merged commit 09837cf into 3.0 Apr 14, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants