Skip to content

Convert websocket URLs to HTTP instead of raising findings#3037

Merged
liquidsec merged 1 commit into3.0from
websocket-url-fix
Apr 14, 2026
Merged

Convert websocket URLs to HTTP instead of raising findings#3037
liquidsec merged 1 commit into3.0from
websocket-url-fix

Conversation

@liquidsec
Copy link
Copy Markdown
Contributor

@liquidsec liquidsec commented Apr 13, 2026

addresses #1035

Summary

Closes #1035

  • ws:// URLs discovered by excavate are now converted to http:// and emitted as URL_UNVERIFIED events
  • wss:// URLs are converted to https:// and emitted as URL_UNVERIFIED events
  • Neither produces a "Non-HTTP URI" FINDING anymore
  • Other non-HTTP schemes (ftp, ldap, smb, etc.) continue to produce findings as before

Websocket endpoints run on the same web server and ports as HTTP, so treating them as standard URLs lets them flow through the normal pipeline (httpx, excavate, etc.) instead of generating noise.

@github-actions
Copy link
Copy Markdown
Contributor

📊 Performance Benchmark Report

Comparing 3.0 (baseline) vs websocket-url-fix (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 4.14ms 4.29ms +3.5%
Bloom Filter Large Scale Dns Brute Force 17.49ms 17.62ms +0.7%
Large Closest Match Lookup 361.56ms 337.43ms -6.7%
Realistic Closest Match Workload 190.15ms 187.00ms -1.7%
Event Memory Medium Scan 1784 B/event 1784 B/event +0.0%
Event Memory Large Scan 1768 B/event 1768 B/event +0.0%
Event Validation Full Scan Startup Small Batch 415.08ms 410.42ms -1.1%
Event Validation Full Scan Startup Large Batch 563.85ms 585.35ms +3.8%
Make Event Autodetection Small 30.65ms 31.36ms +2.3%
Make Event Autodetection Large 314.13ms 317.07ms +0.9%
Make Event Explicit Types 13.66ms 13.99ms +2.4%
Excavate Single Thread Small 3.961s 3.982s +0.5%
Excavate Single Thread Large 9.522s 9.516s -0.1%
Excavate Parallel Tasks Small 4.172s 4.123s -1.2%
Excavate Parallel Tasks Large 7.268s 7.221s -0.6%
Is Ip Performance 3.22ms 3.17ms -1.7%
Make Ip Type Performance 11.69ms 11.46ms -2.0%
Mixed Ip Operations 4.57ms 4.50ms -1.6%
Memory Use Web Crawl 40.6 MB 40.5 MB -0.4%
Memory Use Subdomain Enum 19.4 MB 19.3 MB -0.1%
Scan Throughput 100 7.833s 8.243s +5.2%
Scan Throughput 1000 42.471s 43.064s +1.4%
Typical Queue Shuffle 65.55µs 64.86µs -1.1%
Priority Queue Shuffle 741.34µs 723.25µs -2.4%

🎯 Performance Summary

No significant performance changes detected (all changes <10%)


🐍 Python Version 3.11.15

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91%. Comparing base (39b9d31) to head (5a0d8d4).
⚠️ Report is 11 commits behind head on 3.0.

Files with missing lines Patch % Lines
...t/test_step_2/module_tests/test_module_excavate.py 93% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             3.0   #3037   +/-   ##
=====================================
+ Coverage     91%     91%   +1%     
=====================================
  Files        440     440           
  Lines      37411   37429   +18     
=====================================
+ Hits       33890   33910   +20     
+ Misses      3521    3519    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liquidsec liquidsec merged commit c25ea68 into 3.0 Apr 14, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants