Convert websocket URLs to HTTP instead of raising findings#3037
Merged
Convert websocket URLs to HTTP instead of raising findings#3037
Conversation
Contributor
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary✅ No significant performance changes detected (all changes <10%) 🐍 Python Version 3.11.15 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.0 #3037 +/- ##
=====================================
+ Coverage 91% 91% +1%
=====================================
Files 440 440
Lines 37411 37429 +18
=====================================
+ Hits 33890 33910 +20
+ Misses 3521 3519 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheTechromancer
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #1035
Summary
Closes #1035
ws://URLs discovered by excavate are now converted tohttp://and emitted asURL_UNVERIFIEDeventswss://URLs are converted tohttps://and emitted asURL_UNVERIFIEDeventsWebsocket endpoints run on the same web server and ports as HTTP, so treating them as standard URLs lets them flow through the normal pipeline (httpx, excavate, etc.) instead of generating noise.