Updates "link" header access in populatePageCursor to be case-insensitive#148
Open
dbrudner wants to merge 2 commits intoblacklightcms:masterfrom
Open
Updates "link" header access in populatePageCursor to be case-insensitive#148dbrudner wants to merge 2 commits intoblacklightcms:masterfrom
populatePageCursor to be case-insensitive#148dbrudner wants to merge 2 commits intoblacklightcms:masterfrom
Conversation
dbrudner
changed the title
populatePageCursor to be case-insensitivepopulatePageCursor to be case-insensitive
cristiangraz
requested changes
Oct 22, 2020
Member
cristiangraz
left a comment
cristiangraz
left a comment
There was a problem hiding this comment.
Thanks for catching and contributing! Two quick changes below.
recurly.go
Outdated
| if !ok || len(links) == 0 { | ||
| links := r.Response.Header.Get("Link") | ||
|
|
||
| if len(links) == 0 { |
Member
There was a problem hiding this comment.
to keep consistent with the library's styling, please move this up a line and use if links != "" {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recurly's API recently updated the casing of some response headers. While this doesn't affect this client library at all right now, there is no guarantee that any response header's casing will be the same going forward.
The only header that's accessed in a case-sensitive manner is the "Link" header in the
populatePageCursorfunction. Right now, this works fine, as the "Link" response header hasn't been changed, but this isn't guaranteed to stay this way in the future (see HTTP 1.1 RFC 2616, which states that "field-names are case insensitive" for more info on this).I'd be happy to add an assertion for this as well if it's helpful! Please feel free to respond in the PR or reach out if you have any questions, concerns, or anything at all.