feat(post): add button to hide post in post footer#79
feat(post): add button to hide post in post footer#79jalcine wants to merge 1 commit intoblacksky-algorithms:mainfrom
Conversation
rudyfraser
left a comment
There was a problem hiding this comment.
Thanks for the contribution! A few concerns before this can move forward:
Duplicates existing functionality. There's already a "Hide post for me" option in the post menu (PostMenu/PostMenuItems.tsx).
This PR adds a second entry point without reconciling with it. We'd end up with two different UX paths for the same action.
UX conflict. The existing menu path shows a confirmation prompt saying "This cannot be undone", but this button lets users toggle directly with no confirmation and explicitly supports un-hiding. One of these has to give.
The "Show post" state is unreachable in feeds. Hidden posts get filtered out of feeds by moderationOpts (see src/state/preferences/moderation-opts.tsx). Once a user taps Hide in a feed, the post vanishes, so the toggle's un-hide state never actually renders. Only works in the thread view.
Making this easier to click and irreversibly hide a post forever is something to reconcile
Smaller stuff:
- The interpretFilterAsBlur → interpretFilterAsBlur={true} changes and the isBlocked indent change are unrelated noise. Please drop or split into a separate PR. Unless there's good reason.
TL; DR: Recommend pick one path, menu or button, not both.
|
All good points. I left some of this in mainly to ask what should be the "final" state of this: should it be a permanent affixing in the strip below a post (do we ever see it being needed to be pushed into the menu if/when it's on a mobile view to prevent crowding, for example)? Also TIL re: that point about feed exclusion; I'll remove the inverse state (and seemingly so, probably just move all of the functionality into that button - modal and all). |
Totally the side effect of a |
you can consider just the web context for now. I'm unaware of anyone working on getting the iOS and Android stuff ready. |
This nixes two menu items in favor of showing a button that more prominently allows one to hide a post from their feed.
8d0e968 to
f9c39fb
Compare
|
Rebased the changes so it's focused only on the component and nixed that menu item |
This PR adds a "Hide Post" button, allowing users to hide or unhide posts.