Iss152/release profile debug#153
Open
jmcauley wants to merge 2 commits intoblacksky-algorithms:mainfrom
Open
Conversation
debug = 2 in [profile.release] causes OOM failures in containerized builds (Docker/Podman) due to peak memory pressure at link time when combining full optimization and full DWARF debug info across ~50 transitive dependencies. Introduces a [profile.profiling] profile for developers who need symbolized release builds (e.g. for use with samply, perf, Instruments). Release builds used in CI and Docker are now lean by default. Fixes blacksky-algorithms#152 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When running docker build from rsky-pds/, the build context is the rsky-pds/ directory. The COPY instructions were using paths prefixed with rsky-pds/ (e.g. COPY rsky-pds/src) which resolved incorrectly against the build context and caused the build to fail at the source overlay step. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
Would it be possible to revise this PR so that either all dockerfiles have conformity with copying dataand the CI will build the dockerfiles + a second PR for the optimization parameters? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes OOM (out-of-memory) failures when building
rsky-pdsin containerized environments(Docker/Podman). Full debug symbols in
[profile.release]caused the linker to be killedby the OS during the
rsky-pdslink step due to peak memory pressure from combiningopt-level=3anddebuginfo=2across ~50 transitive dependencies.Also fixes a pre-existing bug in
rsky-pds/DockerfilewhereCOPYsource paths wereincorrect for the build context, causing the second build stage to always fail.
Related Issues
Closes #152
Changes
Checklist
docker build .completes successfully fromrsky-pds/with 8 GB containermemory after both fixes. Previously failed with
SIGKILL(OOM) at thersky-pdslinkstep.
cargo build --profile profiling -p rsky-pds