fix: refactor git-courer permissions and update hook event tracking#196
Merged
Conversation
WHY The previous permission model merged all commands into a single bucket, creating security gaps where dangerous operations could execute without explicit blocking. Additionally, the PreInvocation event was not being tracked by git-courer, causing monitoring failures for workflow initiation. WHAT * Added dedicated block key settings to explicitly deny shell access and isolate restricted actions from general asks. * Replaced deprecated 'PreInvocation' string literal with 'UserPromptSubmit' in hook mappings. * Implemented cleanup logic to remove redundant entries across allow, ask, and block sections during merging.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
The previous permission model merged all commands into a single bucket, creating security gaps where dangerous operations could execute without explicit blocking. Additionally, the PreInvocation event was not being tracked by git-courer, causing monitoring failures for workflow initiation.
WHAT
Closes #
Summary
Changes
Test Plan