fix(session): clear activeSession pointer on discard to prevent MCP server lockup#201
Merged
Merged
Conversation
…erver lockup Bug #197: session discard leaves MCP server in unusable state because handleDiscard() removes the worktree but never calls clearActiveSessionIfMatch(). After discard, any tool call fails with 'chdir ../git-courer-worktrees/<id>: no such file or directory'. Fix: add h.clearActiveSessionIfMatch(sess.ID) in handleDiscard() after store.Delete, matching the same pattern already used in handleFinish(). Closes #197
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #197
Summary
handleDiscard()now callsclearActiveSessionIfMatch()after removing the worktree, matching the same pattern already used inhandleFinish()chdir: no such file or directoryactiveSessionis nil after discardChanges
internal/delivery/mcp/session/session.goh.clearActiveSessionIfMatch(sess.ID)inhandleDiscard()afterstore.Deleteinternal/delivery/mcp/session/session_test.goTestHandleDiscard_RemovesWorktreeBranchMetadatato pre-select session and assert active pointer is clearedTest Plan
go test ./internal/delivery/mcp/session/...— 27/27 tests passgo build ./...— passes