Open
Conversation
This was referenced Mar 5, 2022
Open
Author
|
What is prohibiting this change ? |
Collaborator
|
It should already be fixed by #28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The detection of the end of the payload is wrong. There are 3 bytes after the payload. What the current implementation does it searching from the end backwards for the '}' character. I assume that these 3 extra bytes contain a checksum of some sort since the data can be any value. If one of those 3 bytes happen to be 0x125 which is the same as the '}' character, the detection is wrong and you end up with payloads like {"id":"3"}} or {"id":"4"}B} which are obviously not the correct payloads.