Open
Conversation
In this commit, MemFS only supports absolute symlinks and can only open them when the link is at the end of the path (no interior links). Co-authored-by: Goutam Tadi <gtadi@pivotal.io> Co-authored-by: David Sharp <dsharp@pivotal.io>
dsharp-pivotal
force-pushed
the
pr/symlink-support
branch
from
315d417 to
faa582f
Compare
Contributor
Author
|
Hi @blang Can you take a look at this PR? We've been using this code for a while now in our tests, and it is working without problem for us. I fixed the gofmt issue Travis was reporting. The remaining failure looks like a config issue. |
|
hmm this would be nice :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @blang,
This PR adds support for the Symlink method to vfs. This is pretty straight forward on all Filesystem implementations except for MemFS, of course. In MemFS, it's probably still not a perfect analog of an OS filesystem, but I think it's a close enough start.
Thanks,
d#
CC: @goutamtadi1 @larham