Remove error namespace#18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the initial design, I based the implementation on the
errornamespace because that was the established practice inasio. Looking at the library now, there is a conceptual difference between aero and asio: asio uses a regularenum, which causes its errors to propagate tonamespace error, making error handling as pleasant and familiar as possible:asio::error::not_connected, whereasaerouses anenum class. I suspect thatasiouses regular enums because enum classes were introduced in C++11, and asio needs to support earlier standards. In the end, it seems to me that, to maintain a consistent API, the decision was made not to switch to enum classes at all after C++11 (which isn’t so bad, but I think it just complicates the naming of error codes).What I'm getting at is this: this PR eliminates the need for users to write something like
websocket::error::handshake_error::status_code_invalid,allowing them to shorten the code to
websocket::handshake_error::status_code_invalid.And while this is still isn't short, it's clearly the best compromise between readability and simplicity at this point.