Skip to content
This repository was archived by the owner on Jul 4, 2023. It is now read-only.

Issue #203 Fixed: Deleting Character Now Updates DOM#263

Open
RyuGuardian wants to merge 1 commit into
masterfrom
AK/delete-character
Open

Issue #203 Fixed: Deleting Character Now Updates DOM#263
RyuGuardian wants to merge 1 commit into
masterfrom
AK/delete-character

Conversation

@RyuGuardian
Copy link
Copy Markdown
Collaborator

  • Fixed back-end response to AJAX request
  • jQuery now removes card from UI on success

 - Fixed back-end response to AJAX request
 - jQuery now removes card from UI on success
@RyuGuardian RyuGuardian changed the title Deleting Character Now Updates DOM - Issue #203 Issue #203 Fixed: Deleting Character Now Updates DOM Jul 13, 2019
@RyuGuardian RyuGuardian requested a review from bleehu July 13, 2019 21:39
Copy link
Copy Markdown
Collaborator

@Turtlelord26 Turtlelord26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lost a line of logging (old line 7) in character_select.js. Intentional?
Otherwise looks good to me.

Copy link
Copy Markdown
Owner

@bleehu bleehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great work! Shipit!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants