Final cross-check: README↔proposal consistency + green suite (STE-57)#9
Merged
Merged
Conversation
Consistency pass between README and docs/ARCHITECTURE.md:
- Align source-mode vocabulary: the proposal's /v1 source_mode enum now matches
the reader's emitted modes (public-repo | hosted-tarball |
hosted-tarball-unpinned | content-addressed | none) and the README table; §3
mode headers name the canonical identifiers.
- Align minor README↔proposal drift: roadmap milestone titles (phases 2-3) and
the badge endpoint parameter ({contractId}).
Verified green at submission: contract cargo tests (3/3), reader unit tests
(66 pass, 3 integration), reader + contract builds (hash 6fe7bd58…), live
testnet integration (3/3), and every README quick-start command incl. the
tarball+docker flow and the end-to-end driver.
yvesfracari
force-pushed
the
pedro/ste-57-final-cross-check
branch
from
60c2aeb to
406bc8b
Compare
yvesfracari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of STE-57. Pre-submission quality gate for the grant proposal.
README ↔ proposal consistency
Cross-checked verdicts, image-trust tiers, source-mode names, API endpoints, milestones, and the SEP-55-as-complementary framing across
README.mdanddocs/ARCHITECTURE.md, and against the shipped code. Findings and fixes:/v1source_modeenum readrepo | tarball | content-addressed, which matched neither the code nor the README. Aligned it to the reader's emitted modes —public-repo | hosted-tarball | hosted-tarball-unpinned | content-addressed | none(reader/src/sep58.ts) — and named the canonical identifiers in the §3 mode headers.{contractId}) in the README now matchdocs/ARCHITECTURE.md.FULL_MATCH/METADATA_ONLY_MATCH/NO_MATCH/ERROR), image-trust tiers (sdf-trusted/publicly-auditable/arbitrary/unknown), API endpoints, Phase-0 decisions (ed25519-signed per-verifier results, eviction-downgrades-never-deletes,/v1shape). No SCF tranche framing and no SEP-55-inferior framing anywhere.Green repo at submission
All run from the pinned toolchain (rust 1.91.1, node 24.11.0, stellar-cli 26.1.0):
cargo test --locked— 3/3 passpnpm test— 66 pass, 3 integration skipped (opt-in)pnpm run build+stellar contract build --locked— clean; wasm hash6fe7bd58e5a33dc27daefc74acfae6eb70f101fdbde860475cf18fde87288e4bread(by id and by--wasm-hash, text and--json),verify --wasm(FULL_MATCH, exit 0),verify --tarball … --docker(FULL_MATCH), thescripts/verify.shdriver (plain and tarball+docker), and the "Build images"docker build+docker run --network=nonesnippet (reproduces the same hash).