Skip to content

fix: drain queued branch sessions from backend lifecycle#579

Merged
matt2e merged 3 commits intomainfrom
not-queued
Apr 2, 2026
Merged

fix: drain queued branch sessions from backend lifecycle#579
matt2e merged 3 commits intomainfrom
not-queued

Conversation

@matt2e
Copy link
Copy Markdown
Contributor

@matt2e matt2e commented Apr 2, 2026

Summary

  • move queued branch session draining into backend lifecycle hooks so queue progression no longer depends on the frontend listener
  • drain the next queued branch session after orphaned running sessions are recovered on startup
  • add shared backend helpers to resolve a session's branch and start the oldest queued branch session safely

matt2e added 2 commits April 2, 2026 13:44
Drain the next queued branch session after orphaned running sessions are recovered at startup. Reuse the app session registry during recovery and clarify the queue-drain and branch-resolution assumptions in docs.
@matt2e matt2e requested review from baxen and wesbillman as code owners April 2, 2026 05:40
Re-add the commands API import in sessionStatusListener so PR and push completion handlers typecheck again after the queue-drain cleanup removed the import.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2205fe491c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".


import { listen, type UnlistenFn } from '@tauri-apps/api/event';
import * as commands from '../api/commands';
import {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Re-add commands import in session status listener

The listener still uses commands.getSessionMessages, commands.updateBranchPr, commands.refreshPrStatus, and commands.clearBranchPrStatus, but this commit removed the commands import. That makes PR/push completion handling fail (TypeScript compile error or runtime ReferenceError when those handlers run), so users will lose PR URL parsing/status updates after sessions complete.

Useful? React with 👍 / 👎.

@matt2e matt2e merged commit cafbb88 into main Apr 2, 2026
4 checks passed
@matt2e matt2e deleted the not-queued branch April 2, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant