fix: restore resume session metadata for resumed actions#580
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5cc1e8a5ce
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } else if let Some(note) = &linked_note { | ||
| store.get_branch(¬e.branch_id).ok().flatten() | ||
| } else if let Some(review) = &linked_review { | ||
| store.get_branch(&review.branch_id).ok().flatten() |
There was a problem hiding this comment.
Falling back to linked_note/linked_review here sets linked_branch (and later workspace_name) even when branch_id was not passed to resume_session, but remote_working_dir is still only resolved from branch_from_id later in this function. In the Session Launcher flow (SessionModal opened without a branchId), resuming a remote note/review session will therefore run via workspace ACP with no repo path override, so commands execute in the workspace default directory instead of the branch repo/subpath. This can make resumed actions fail or operate on the wrong repo for multi-repo/subpath workspaces.
Useful? React with 👍 / 👎.
1 participant
Summary