fix(desktop): use augmented PATH for readiness probes#1613
Open
Areson wants to merge 1 commit into
Open
Conversation
Areson
force-pushed
the
Areson/fix-codex-readiness-path
branch
from
1ea100a to
517e9f9
Compare
Co-authored-by: Ian Oberst <ioberst@squareup.com> Signed-off-by: Ian Oberst <ioberst@squareup.com> Co-authored-by: Codex <noreply@openai.com> Ai-assisted: true
Areson
force-pushed
the
Areson/fix-codex-readiness-path
branch
from
517e9f9 to
a2a90be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Packaged desktop launches can have a sparse GUI PATH. Readiness probes resolved the Codex/Claude binary but then ran it without the augmented PATH used for agent startup, so npm shims with
/usr/bin/env nodecould fail before checking login state.What
/usr/bin/env nodeshimscodex loginand remove an unused runtime re-export that blocked targeted clippyRisk Assessment
Low — scoped to desktop managed-agent readiness probes and setup nudge copy. Probe execution still uses the resolved absolute binary path and only augments PATH for child process interpreter lookup.
References
./bin/just desktop-tauri-fmt-checkpnpm --dir desktop check:file-sizes./bin/just desktop-tauri-testcheck-push-org,rust-tests,desktop-test,desktop-tauri-test,mobile-test./bin/just desktop-tauri-clippycurrently fails on broader existing Tauri warnings outside this PR; not expanded here.Generated with Codex