-
Notifications
You must be signed in to change notification settings - Fork 35
feat(desktop): flapping bee on the setup loading screen #1631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8973123
feat(desktop): animated bee on loading gates
5d9c107
feat(desktop): restore theme-adaptive grainient setup screen with bee…
f4f3e44
feat(desktop): flap the setup-gate bee's wings
fe55729
fix(desktop): start the setup-gate bee mid-flap so a warm refresh isn…
a806e48
fix(desktop): run the setup-gate wing flap on the compositor so refre…
klopez4212 c225b7e
fix(desktop): size the switch-gate bee to the mark and seed dark them…
b3df889
feat(desktop): hold the boot splash so the bee is actually seen on co…
klopez4212 528c211
fix(desktop): boot the window visible so WebKit's animation machinery…
klopez4212 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| export function ThemeGrainientBackground() { | ||
| return ( | ||
| <div | ||
| aria-hidden="true" | ||
| className="buzz-setup-grainient" | ||
| data-testid="setup-grainient-background" | ||
| > | ||
| <div className="buzz-setup-grainient__wash" /> | ||
| <div className="buzz-setup-grainient__veil" /> | ||
| </div> | ||
| ); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the cached theme is anything other than the built-in Catppuccin light/dark vars, this only copies
--backgroundintohtml.style.backgroundColorand then adds a light/dark class. Fresh evidence beyond the prior thread is thatThemeProvider.applyCachedVars()reapplies the entire cachedvarsmap (desktop/src/shared/theme/ThemeProvider.tsx:224-228), whilebodyand the new loading gate readvar(--background),--chart-*, etc. from CSS variables before React mounts; with a cached Houston/Buzz/custom theme the pre-React paint still uses the static Catppuccin variables and can flash the wrong themed splash until the bundle runs. Seed the cached vars ondocumentElement.stylehere before adding the class.Useful? React with 👍 / 👎.