Skip to content

fix(desktop): paint Buzz gradient on the workspace rail#1636

Merged
klopez4212 merged 1 commit into
mainfrom
kennylopez-rail-gradient
Jul 8, 2026
Merged

fix(desktop): paint Buzz gradient on the workspace rail#1636
klopez4212 merged 1 commit into
mainfrom
kennylopez-rail-gradient

Conversation

@klopez4212

@klopez4212 klopez4212 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Problem

When the workspaceRail experiment is enabled, the Discord-style relay
column (the "relay rail") on the far left did not pick up the Buzz
branded gradient — it rendered as flat grey while the sidebar next to it
carried the gradient, breaking the continuous-canvas look.

Root cause

The branded gradient selector is scoped to bg-sidebar surfaces inside
.group/sidebar-wrapper. But the WorkspaceRail <nav> is rendered as a
sibling of that wrapper in AppShell (it sits outside so it can span
the full height alongside the collapsible sidebar). Its bg-sidebar class
therefore never matched the gradient rule and fell back to the flat grey
--sidebar-background.

Fix

Add a precise selector for [data-testid="workspace-rail"].bg-sidebar to
the gradient rule — the same "own selector for a surface outside the
wrapper" pattern already used for the portaled mobile sidebar sheet. Because
the gradient is background-attachment: fixed sized to 100vw 100vh, the
rail and sidebar align pixel-for-pixel and read as one continuous surface.

Verification

  • just ci green (fmt + clippy + desktop lint + unit tests + builds + mobile).
  • Extended buzz-theme-screenshots.spec.ts with light + dark rail cases that
    clip across rail + sidebar to guard against regression. All 7 theme
    screenshot tests pass.

Buzz Light — rail + sidebar

light

Buzz Dark — rail + sidebar

dark

klopez4212 pushed a commit that referenced this pull request Jul 8, 2026
@klopez4212

Copy link
Copy Markdown
Contributor Author

Buzz Light — rail + sidebar

The relay rail (far left, A/B/+ buttons) now flows into the same top→bottom gradient as the sidebar.

06-buzz-light-rail

Buzz Dark — rail + sidebar

Same seamless canvas in the dark variant.

07-buzz-dark-rail

@klopez4212 klopez4212 requested a review from wesbillman July 8, 2026 14:53
Comment thread desktop/tests/e2e/buzz-theme-screenshots.spec.ts Outdated
@klopez4212 klopez4212 force-pushed the kennylopez-rail-gradient branch from edaef89 to 2833487 Compare July 8, 2026 15:05
The branded sidebar gradient is scoped to bg-sidebar surfaces inside
.group/sidebar-wrapper, but the workspace rail (the Discord-style relay
column shown behind the workspaceRail preview flag) renders as a sibling
of that wrapper. With the Buzz theme active the rail therefore fell back
to flat grey --sidebar-background, breaking the continuous canvas.

Add a precise selector for [data-testid="workspace-rail"].bg-sidebar
(same pattern already used for the portaled mobile sidebar sheet) so the
rail carries the same viewport-fixed gradient and reads as one continuous
surface with the sidebar.

Signed-off-by: npub13fn4ahfnvaa2qwylvegdgeajqs0mph6v4qsw4jcqnw4mjh3hzh2quuucm5 <8a675edd33677aa0389f6650d467b2041fb0df4ca820eacb009babb95e3715d4@sprout-oss.stage.blox.sqprod.co>
@klopez4212 klopez4212 force-pushed the kennylopez-rail-gradient branch from 2833487 to 35b1f71 Compare July 8, 2026 15:06
@klopez4212 klopez4212 merged commit 2f1cd67 into main Jul 8, 2026
25 checks passed
@klopez4212 klopez4212 deleted the kennylopez-rail-gradient branch July 8, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants