test: windows CI canary (do not merge)#1638
Closed
wpfleger96 wants to merge 4 commits into
Closed
Conversation
import_identity wrote only to identity.key and never to the keyring, so the shadow key from first boot always won on every subsequent launch. The Present-branch boot cleanup then deleted identity.key without comparing pubkeys, discarding the imported key silently. On a clean keyring with a migration marker but no file, a new identity was generated without any user intent, completing the re-onboarding loop. Import now persists keyring-first with read-back verify and file fallback; boot resolution adopts a mismatched identity.key as the user's explicit intent (surviving transient keyring failures); marker + empty keyring boots a lost-identity recovery flow, and an unreachable keyring boots a blocking unlock-and-relaunch screen instead of aborting launch. Recovery boots gate all signing commands, skip owner-keyed startup routines, enforce a relaunch after re-import, and persist "start new identity" durably.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 temporary draft PR — bisecting a deterministic STATUS_ENTRYPOINT_NOT_FOUND in the Windows Rust job on #1568. Phase A: origin/main + trivial Rust comment. Phase B will cherry-pick the #1568 commit. Will be closed and deleted after diagnosis.